Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testhelpers' code to _test.go file #1049

Closed
wants to merge 3 commits into from

Conversation

dmlambea
Copy link
Contributor

Fixes #1048

@cla-assistant
Copy link

cla-assistant bot commented Aug 23, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Aug 23, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@milindl
Copy link
Contributor

milindl commented Oct 6, 2023

Thanks for this change @dmlambea
Could you sign the CLA for this change, I'll run it on an internal CI branch to merge it.

@dmlambea
Copy link
Contributor Author

dmlambea commented Oct 9, 2023

Thanks for this change @dmlambea Could you sign the CLA for this change, I'll run it on an internal CI branch to merge it.

I've done it already. It seem the "CLA not signed yet" comment has been registered after the "CLA signed" one.

@milindl
Copy link
Contributor

milindl commented Oct 9, 2023

Right @dmlambea , I think the CLA signatures got reset for some reason for all the contributors at once. Could you retry signing it once, if that works? Thanks

@dmlambea
Copy link
Contributor Author

dmlambea commented Oct 9, 2023

Right @dmlambea , I think the CLA signatures got reset for some reason for all the contributors at once. Could you retry signing it once, if that works? Thanks

I've retried a minute ago with success. cla-assistant.io says: "You have agreed to the CLA for confluentinc/confluent-kafka-go" and below there is the version of the CLA (2023-08-04) along with the complete text and my personal data.

@milindl
Copy link
Contributor

milindl commented Oct 10, 2023

Thank you. I created the internal branch and raised a PR with that so the CI can run. #1077

@milindl
Copy link
Contributor

milindl commented Oct 10, 2023

Merged the internal branch after CI checks.
Thanks for the issue and the PR @dmlambea !

@milindl milindl closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'testing' is imported in non-test files (testhelpers.go)
2 participants