Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate msg.LeaderEpoch #1012

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jun 20, 2023

msg.TopicPartition.LeaderEpoch is used when storing offsets, that field now is also used when returning the leader epoch associated to the message, similar to what happens with the offset.

@emasab emasab requested a review from milindl June 20, 2023 19:08
@emasab
Copy link
Contributor Author

emasab commented Jun 20, 2023

Fixes failing test TestIntegration/TestConsumerSeekPartitions

Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. added PR#

@milindl milindl merged commit a6edcae into master Jun 26, 2023
@milindl milindl deleted the dev_deprecate_message_leader_epoch branch June 26, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants