Fix nil pointer error on schemaregistry/serde/protobuf/protobuf.go (#997

) * fix nil pointer error * Add CHANGELOG.md entry --------- Co-authored-by: xinyu.liu <[email protected]>
confluentinc · May 16, 2023 · 2d73ce6 · 2d73ce6
1 parent ae8907e
commit 2d73ce6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Confluent's Golang client for Apache Kafka
 
+# v2.2.0
+
+This is a feature release.
+
+## Fixes
+
+ * Fixes a nil pointer bug in the protobuf `Serializer.Serialize()`, caused due to
+   an unchecked error (#997, @baganokodo2022).
+
+
 ## v2.1.1
 
 This is a maintenance release.

diff --git a/schemaregistry/serde/protobuf/protobuf.go b/schemaregistry/serde/protobuf/protobuf.go
@@ -193,10 +193,10 @@ func (s *Serializer) Serialize(topic string, msg interface{}) ([]byte, error) {
 
 func (s *Serializer) toProtobufSchema(msg proto.Message) (*desc.FileDescriptor, map[string]string, error) {
 	messageDesc, err := desc.LoadMessageDescriptorForMessage(protoV1.MessageV1(msg))
-	fileDesc := messageDesc.GetFile()
 	if err != nil {
 		return nil, nil, err
 	}
+	fileDesc := messageDesc.GetFile()
 	deps := make(map[string]string)
 	err = s.toDependencies(fileDesc, deps)
 	if err != nil {