Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Send -9 on cleanup interruption #510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Mar 3, 2025

we are using "timeout" to limit cleanup time in CI, but the default -15 won't interrupt on some occasions. Let's use -9 instead to not to block in case the cleanup fails.

Note this is only about the cleanup part of the e2e run-local.sh, every hang inside the testing itself should still result in a failure.

we are using "timeout" to limit cleanup time in CI, but the default -15
won't interrupt on some occasions. Let's use -9 instead to not to block
in case the cleanup fails.

Note this is only about the cleanup part of the e2e run-local.sh, every
hang inside the testing itself should still result in a failure.

Signed-off-by: Lukáš Doktor <[email protected]>
@ldoktor ldoktor requested a review from a team as a code owner March 3, 2025 12:23
@ldoktor
Copy link
Contributor Author

ldoktor commented Mar 3, 2025

Related discussion: #508 (comment)

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ldoktor!

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants