-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot: Group dependabot PRs #509
base: main
Are you sure you want to change the base?
Conversation
this should group all dependabot PRs, which should decrease the amount of CI and acks for GH action version changes. Signed-off-by: Lukáš Doktor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mythi we should dos this for all our repos probably
I approved this, but I guess the counter argument to this out is that if there is a case of a breaking change in one of the GHA the dependabot bumps to, then having them all grouped might make unpicking that more tricky (I'm not sure if there is a single PR with a commit per bump, or another way), so my suggestion would be to see how it goes in this repo for a bit and then review before rolling out? |
Hm that is a good point. One sort-of related thing we might want to change in the other repos is the frequency of the updates. We are doing them daily in most places, which might be overkill. |
This is exactly why I started here, to test things out and eventually do the same everywhere. TBH I don't even know whether this works. I just searched for it and found docs mentioning it should be possible with different examples. All in all, lets evaluate this next month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ldoktor , that's a great idea. Let's see how it goes.
this should group all dependabot PRs, which should decrease the amount of CI and acks for GH action version changes.