Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable CodeQL checks #425

Merged
merged 2 commits into from
Sep 2, 2024
Merged

enable CodeQL checks #425

merged 2 commits into from
Sep 2, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Aug 26, 2024

This PR is a reference for few improvements in our repositories

  1. enable dependabot github-actions updates using pinned versions (dependabot understands pinned versions nowadays). Pinned versions are considered safe since attackers could re-push tags. The move to pinned versions must be done manually.
  2. enable CodeQL checks for our Go based code (to be checked: maintainers might have to enable this in the repo settings also)

Ref: confidential-containers/confidential-containers#46

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mythi mythi requested review from ldoktor and bpradipt August 26, 2024 14:50
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess this might create a bit more work for us tho. We'll see what the results are.

@mythi
Copy link
Contributor Author

mythi commented Aug 26, 2024

I did a test run in my fork and checked the results. It did not show up anything that would trigger any actions.

@mythi
Copy link
Contributor Author

mythi commented Aug 29, 2024

@bpradipt is this OK to merge?

@bpradipt
Copy link
Member

@mythi missed this.. LGTM

@mythi mythi removed the request for review from ldoktor August 29, 2024 06:58
@fitzthum
Copy link
Member

CI is stuck 😞

@mythi
Copy link
Contributor Author

mythi commented Aug 30, 2024

CI is stuck 😞

@BbolroC @bpradipt do I need an ok-to-test label here?

@mythi
Copy link
Contributor Author

mythi commented Aug 30, 2024

This can be merged now. Some tests are failing but most likely not related to this PR.

@mythi
Copy link
Contributor Author

mythi commented Sep 2, 2024

I have two approvals and CI is green so merging.

@mythi mythi merged commit 8e0d2b7 into confidential-containers:main Sep 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants