-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable CodeQL checks #425
enable CodeQL checks #425
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess this might create a bit more work for us tho. We'll see what the results are.
I did a test run in my fork and checked the results. It did not show up anything that would trigger any actions. |
@bpradipt is this OK to merge? |
@mythi missed this.. LGTM |
CI is stuck 😞 |
This can be merged now. Some tests are failing but most likely not related to this PR. |
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
I have two approvals and CI is green so merging. |
This PR is a reference for few improvements in our repositories
Ref: confidential-containers/confidential-containers#46