ccruntime: processCcRuntimeDeleteRequest split #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldoktor
reviewed
Aug 19, 2024
ldoktor
reviewed
Aug 19, 2024
ldoktor
reviewed
Aug 19, 2024
We are currently experiencing issues with finalizers hanging when deleting ccruntime. Initial debugging has pinpointed the problem to the processCcRuntimeDeleteRequest method. This method is large and has a cyclomatic complexity of 21. We should take this opportunity to use early returns to reduce nesting and simplify control flow. Additionally, this is moving the finalizer handling logic to its own method. This refactor should not change the current logic, only improve readability and maintainability. Related to confidential-containers#391. Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
clean-refact
branch
from
aa7b076 to
42aec49
Compare
Those were good catches. Thanks. Let me know if you are ok with the changes. |
ldoktor
approved these changes
Aug 21, 2024
|
@wainersm do you mind reviewing again, since I force pushed with some changes? |
|
@stevenhorsman @fidencio can one of you trigger the e2e CI. Looks like it's stuck. |
You need the |
Oh ok.. |
|
Merging this as CI passed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently experiencing issues with finalizers hanging when deleting ccruntime. Initial debugging has pinpointed the problem to the processCcRuntimeDeleteRequest method.
This method is large and has a cyclomatic complexity of 21. I'm taking this opportunity to use early returns to reduce nesting and simplify control flow. Additionally, this is moving the finalizer handling logic to its own method.
This refactor should not change the current logic, only improve readability and maintainability.
Related to #391.