-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payloads for v0.9.0-alpha0 #368
Conversation
Update the enclave-cc payloads to point to the v0.9.0 release of enclave-cc and update the pre-reqs bundle even though enclave-cc doesn't actually use nydus yet. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Update Kata payloads to 3.4.0 and bump the reqs deploy payload. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Hey @fitzthum, are you talking about the
in the s390x kustomization.yaml? or on the kata-deploy image tag: |
Enclave-cc now uses a "unified bundle" which means that the paths to a few things have changed. This was already accounted for in the cicd workflow, but the e2e test was not modified. Copy the change from the cicd workflow. We might adopt a change without sed in the future. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
enclave-cc issue has been resolved thanks to @portersrc @confidential-containers/operator-maintainers PTAL so we can finish the release |
The enclave-cc fix looks OK for the moment, but it would be good for @mythi to take a look later (e.g. his recent commit message here suggests he may have a better long-term idea for this). @stevenhorsman , do you know if we need to update this line yet? I see you were active here when we swapped 0.8.0 back to latest. I assume it needs to be set to 0.9.0-alpha0 at some point. @bpradipt , do you have thoughts on needed changes for v0.9.0-alpha0 release here? Also, is This ssh-demo case is odd. I would ignore. Technically I think reqs-payload should be for this release, but I don't know if that's even tested (or maybe it's part of the CI?). |
Last release it was updated as part of the operator hub piece: 2a05696#diff-14effe9ea1a3ddb6e419e627a3501a6c42aa2dcbc76803923e9aff2438e6ee34 and as it is referencing the operator image release tag which we haven't cut I don't think it can be done now.
The update for this has not been merged: https://github.com/confidential-containers/operator/pull/362/files. I was assuming that it was being left until after the 0.9 release as peer pods isn't part of it?
Tobin has created a discussion to remove it #370, but if we aren't doing it for this release (and I think it's probably too late for that), then I think we just bump it, but nobody is testing it, and I don't think it is considered supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevenhorsman for clearing some doubts. Looks OK to me now.
I think for this release we may forego the operator hub bit anyway since it is an alpha release and Wainer is on vacation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @fitzthum!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
apologies, I had completely missed this. I can get things properly fixed once the release is out (essentially just getting the test/e2e/ yamls updated.) |
The payloads for v0.9.0-alpha
@stevenhorsman or @BbolroC can you guys confirm that we do not need the s390x suffix for the s390x CRD?