Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: update docker manifest create commands #366

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Release: update docker manifest create commands #366

merged 2 commits into from
Apr 29, 2024

Conversation

portersrc
Copy link
Member

This is attempting to fix the failing GHA action here so that the v0.9.0 release can continue.

docker manifest create example is here:

docker manifest create 45.55.81.106:5000/coolapp:v1 \
    45.55.81.106:5000/coolapp-ppc64le-linux:v1 \
    45.55.81.106:5000/coolapp-arm-linux:v1 \
    45.55.81.106:5000/coolapp-amd64-linux:v1 \
    45.55.81.106:5000/coolapp-amd64-windows:v1

ldoktor
ldoktor approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but before the merge please improve the commit message to clearly state why the change is required (the amend one, build is a typo fix which should be ideally a separate commit but I don't think coco op follows that strict rules)

@portersrc
Release: update docker manifest create commands
009ef64 
This docker command is an experimental feature currently.
It seems the amend switches are unneeded and that these
"manifest" parameters should simply follow the "manifest-list"
parameter

Signed-off-by: Chris Porter <[email protected]>
@portersrc
Release: minor typo fix
beaa087 
Signed-off-by: Chris Porter <[email protected]>
@portersrc portersrc force-pushed the docker-manifest-create-fix branch from 4960874 to beaa087 Compare April 29, 2024 14:37
ldoktor
ldoktor approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great now :-)

fitzthum
fitzthum approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100000 percent sure that this will solve the problem, but it's hard to iterate without merging things so let's give it a go.

@fitzthum fitzthum merged commit db56787 into confidential-containers:main Apr 29, 2024
10 checks passed
@portersrc portersrc deleted the docker-manifest-create-fix branch May 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldoktor ldoktor ldoktor approved these changes

@fitzthum fitzthum fitzthum approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portersrc @ldoktor @fitzthum