Add "make clean" target #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to provide a standard way to clean the environment after build. Signed-off-by: Lukáš Doktor <[email protected]>
wainersm
reviewed
Apr 26, 2024
| @@ -152,6 +152,10 @@ endif | |||
| docker-push: ## Push docker image with the manager. | |||
| docker push ${IMG} | |||
|
|
|||
| .PHONY: clean | |||
| clean: ## Cleanup the build generated files | |||
| rm -Rf bin/ cover.out bundle_tmp* | |||
There was a problem hiding this comment.
There are other make targets that will install binaries under bin/ so I think delete them via rm was the right decision (rather than go clean)
wainersm
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to provide a standard way to clean the environment after build.
Note I'm not a heavy "go" user so I simply took the paths from ".gitignore". I experimented with "go clean" but it did not work for me.