Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use ubuntu-22.04 and not ubuntu-latest in workflows #348

Merged

Conversation

portersrc
Copy link
Member

We should at least be consistent with the ubuntu base images we're running in the workflows. I also opt to use ubuntu-22.04 and not ubuntu-latest.

Other repos in the org can take a similar change if reviewers want.

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better to be explicit. The 22.04 is currently the latest so nothing actually changes but in the future we'd be surprised.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks Chris!

@wainersm
Copy link
Member

wainersm commented Feb 6, 2024

hi @BbolroC !

The s390x post-action step failed: https://github.com/confidential-containers/operator/actions/runs/7796965300/job/21262642550?pr=348

I wondering if there is something we can do to make that step more reliable.

@stevenhorsman
Copy link
Member

stevenhorsman commented Feb 6, 2024

hi @BbolroC !

The s390x post-action step failed: https://github.com/confidential-containers/operator/actions/runs/7796965300/job/21262642550?pr=348

I wondering if there is something we can do to make that step more reliable.

Choi might be able to confirm, but he updated and re-registered the s390x runners earlier, which might have coincided with that run?

I would re-queue, but it looks like we have an issue with getting az-ubuntu-2204 runners that I assume is related to the changes in this PR!

@BbolroC
Copy link
Member

BbolroC commented Feb 6, 2024

@wainersm @stevenhorsman yeah, the time matches. I was in the middle of the update at the time.

@BbolroC
Copy link
Member

BbolroC commented Feb 6, 2024

The test for s390x has been successfully passed. Sorry for the inconvenience.

@GabyCT
Copy link
Contributor

GabyCT commented Feb 6, 2024

lgtm

@ldoktor ldoktor merged commit 206ac43 into confidential-containers:main Feb 7, 2024
11 checks passed
@portersrc portersrc deleted the use-consistent-ubuntu-image branch May 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants