Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: more descriptive filename for enclave cc e2e test #347

Merged

Conversation

portersrc
Copy link
Member

No description provided.

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I'm not 100% sure how github picks the jobs. Anyway I haven't found any references so I assume it simply combines all the files in .github/workflows/* so it should pick it up after the merge. @wainersm can you please confirm this?

@wainersm
Copy link
Member

wainersm commented Feb 6, 2024

Looks good although I'm not 100% sure how github picks the jobs. Anyway I haven't found any references so I assume it simply combines all the files in .github/workflows/* so it should pick it up after the merge. @wainersm can you please confirm this?

That's my understanding too.

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @portersrc !

ps: I re-triggered ccruntime e2e test for PR / e2e-pr / operator tests (kata-qemu, az-ubuntu-2004) because it was stalled.

@wainersm wainersm merged commit e23cf32 into confidential-containers:main Feb 7, 2024
11 checks passed
@portersrc portersrc deleted the change-e2e-yaml-name branch May 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants