tests: Improve variable definition in tests/e2e scripts #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldoktor
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Nice, it'd be even better to fix this issue across all shell scripts within repository (or at least directory). Are you interested in doing it (here or in a following PR), or do you want me to take care of that (I understand it's quite boring, but consistent :D)
|
@ldoktor let me do it |
GabyCT
changed the title
|
Looks good although I spotted a few variables in |
To have a better consistency across the test/e2e scripts this PR improves the variable definition by using local as a best practice. Signed-off-by: Gabriela Cervantes <[email protected]>
|
@ldoktor thanks for the feedback, sorry that I missed those |
ldoktor
approved these changes
Feb 7, 2024
not worries, thanks for the feedback helps me to improve my work |
portersrc
approved these changes
Feb 8, 2024
wainersm
reviewed
Feb 21, 2024
wainersm
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a better consistency across the test/e2e scripts this PR improves the variable definition by using local as a best practice.