Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent yaml file extension #344

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

portersrc
Copy link
Member

No description provided.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Normally convention is that we start our commit headers with the components/area being updated e.g. ci: ..., or workflows: ..., but it's not mandatory and enforced, so doesn't block merging.

@GabyCT
Copy link
Contributor

GabyCT commented Jan 31, 2024

lgtm

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm although you might have also included the tests/e2e/ansible/*.yml files as well ;-)

@portersrc
Copy link
Member Author

LGTM. Normally convention is that we start our commit headers with the components/area being updated e.g. ci: ..., or workflows: ..., but it's not mandatory and enforced, so doesn't block merging.

I'll start doing this, then. "Components/area" seems to be a loose term based on what I've seen people doing, but best effort is still an improvement.

@portersrc
Copy link
Member Author

lgtm although you might have also included the tests/e2e/ansible/*.yml files as well ;-)

Hey say less

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Chris, this seems to cover all yaml files, only the README.md containes 2 more references of yml workflows that needs to be addressed. As for the kube-flannel.yml, I think it would be better to include it as well (including all the files where it's referenced) but I don't say it's a must have.

@wainersm
Copy link
Member

wainersm commented Feb 2, 2024

Thanks @portersrc ! Now we just sit and wait someone send a PR to switch back to .yml ;)

@portersrc
Copy link
Member Author

Now we just sit and wait someone send a PR to switch back to .yml ;)

Yes lol; I'd be fine with that as long as it's consistent.

the README.md containes 2 more references

Thank you! That was sloppy of me.

As for the kube-flannel.yml, I think it would be better to include it as well

OK, giving it a shot.

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's see whether the pipeline failure was just a glitch...

@ldoktor
Copy link
Contributor

ldoktor commented Feb 13, 2024

still looks good, I can see 2 previous acks so let me get this in ;-)

@ldoktor ldoktor merged commit 14a040c into confidential-containers:main Feb 13, 2024
10 checks passed
@portersrc portersrc deleted the fix-yaml-extension branch May 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants