-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent yaml file extension #344
Use consistent yaml file extension #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Normally convention is that we start our commit headers with the components/area being updated e.g. ci: ...
, or workflows: ...
, but it's not mandatory and enforced, so doesn't block merging.
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm although you might have also included the tests/e2e/ansible/*.yml
files as well ;-)
I'll start doing this, then. "Components/area" seems to be a loose term based on what I've seen people doing, but best effort is still an improvement. |
e94656a
to
795d90a
Compare
Hey say less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Chris, this seems to cover all yaml files, only the README.md containes 2 more references of yml workflows that needs to be addressed. As for the kube-flannel.yml
, I think it would be better to include it as well (including all the files where it's referenced) but I don't say it's a must have.
Thanks @portersrc ! Now we just sit and wait someone send a PR to switch back to .yml ;) |
38b8339
to
2925912
Compare
Yes lol; I'd be fine with that as long as it's consistent.
Thank you! That was sloppy of me.
OK, giving it a shot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's see whether the pipeline failure was just a glitch...
2925912
to
61f1044
Compare
Signed-off-by: Chris Porter <[email protected]>
61f1044
to
901b80b
Compare
still looks good, I can see 2 previous acks so let me get this in ;-) |
No description provided.