Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update operator to use release tags for enclave-cc and kata #283

Merged

Conversation

portersrc
Copy link
Member

This covers step 19 from the release checklist here

Update the operator to point to the v0.8.0 tagged enclave-cc bundles
for runtime-payload

Signed-off-by: Chris Porter <[email protected]>
@wainersm
Copy link
Member

wainersm commented Nov 9, 2023

/test

Update the operator to point to the kata-container bundle hash associated
with v0.8.0.

Note: This intentionally uses the runtime-payload-ci hash for this release
due to issues creating the runtime-payload bundles.

Signed-off-by: Chris Porter <[email protected]>
@portersrc
Copy link
Member Author

/test

@portersrc portersrc marked this pull request as ready for review November 9, 2023 22:38
@portersrc
Copy link
Member Author

portersrc commented Nov 9, 2023

The runtime-payload bundles didn't get created due to mishaps in the CI (see here and here). Nevertheless, the v0.8.0 tag was already applied for 8de1f8e (see here), and the runtime-payload-ci kata-container bundles are correctly built for it. This is convenient enough, as we can just stick with this hash for the release.

Note this means that the fix from @littlejawa's PR 8400 is part of v0.8.0 (good), but @fidencio's PR 8415 to tweak the workflow is not (which should be OK, as we're moving off of those files soon).

Before merging, we probably want @wainersm's operator fix, and then the reqs-payload will need to be updated a final time here.

@fidencio
Copy link
Member

/test-s390x

@fidencio
Copy link
Member

@portersrc, we don't need to wait for @wainersm's fixes, to be honest, that can come later, but before the release.
I'll merge this one as soon as all CIs are green.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @portersrc!
/cc @stevenhorsman @bpradipt @wainersm for a review

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @portersrc ,

I liked the comment that you left on the commit:

Note: This intentionally uses the runtime-payload-ci hash for this release
due to issues creating the runtime-payload bundles.

LGTM.

@wainersm wainersm merged commit 4230bc5 into confidential-containers:main Nov 10, 2023
@portersrc portersrc deleted the step-19-operator-bump branch February 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants