-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: set operator payloads for v0.8.0 release #277
config: set operator payloads for v0.8.0 release #277
Conversation
9757ffe
to
5acd1d8
Compare
@portersrc, just one tip, mind the commit message. Here's a little bit of git etiquette that you can get some inspiration from https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 |
For the v0.8.0 release, we need to point the operator to the appropriate ccruntime and enclave-cc hashes for reqs-payload Signed-off-by: Chris Porter <[email protected]>
dd8e541
to
70717b1
Compare
Point the operator to the kata and enclave-cc release candidate bundles for v0.8.0 Signed-off-by: Chris Porter <[email protected]>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -8,10 +8,10 @@ resources: | |||
|
|||
images: | |||
- name: quay.io/confidential-containers/reqs-payload | |||
newTag: latest | |||
newTag: fad6ef4607e929c2d30d16dc8c62fbb29881a44c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need #274 to be merged first before we take the reqs-payload release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plan is to cycle back around and re-bump this once the operator PRs are finished then I'm okay with that, I just wanted to ensure that people were aware that we haven't finished yet, so some of this work will probably need to be redone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah #280 also will change things. I think it is reasonable to pick up these changes later. It seems likely that a bundle that works with the current operator would also work with those PRs merged. Not ideal to have both things moving at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged this one, there are PRs coming on the Operator side; there may be PRs coming on the peer-pods side as well, but I'm fine on having kata-containers side of the things not moing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the understanding that some of the tags will need to be updated before the release is cut, I'm okay with this change.
This covers steps 4 and 5 from the release checklist here