Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snp: add snp testing #197

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

ryansavino
Copy link
Member

Add snp testing

Fixes: #196

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we have kata-containers/tests#5594

Sort of a duplicate of #187

@UnmeshDeodhar
Copy link
Contributor

/test

@UnmeshDeodhar
Copy link
Contributor

/test

1 similar comment
@fidencio
Copy link
Member

/test

@fidencio
Copy link
Member

Oh, I'm glad to see that at least the operator tests for TDX passed (this is not related to this PR though).

Add snp testing

Fixes: confidential-containers#196

Signed-Off-By: Ryan Savino <[email protected]>
@fidencio
Copy link
Member

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, considering all tests pass.

Please, do not merge before having all the TEEs tests passing.

@fidencio fidencio merged commit f3a1054 into confidential-containers:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snp tests
4 participants