Skip to content

fix: return struct instead of interface in logger factory #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: return struct instead of interface in logger factory #212

wants to merge 3 commits into from

Conversation

ArtemIstomin-sm
Copy link
Contributor

@ArtemIstomin-sm ArtemIstomin-sm commented Aug 25, 2025 •
edited
Loading

Summary

  1. Use pointer to struct instead of interface in logger factory
  2. Uppercase name for exported const
  3. Check error and response not nil in workflow_rate_limit_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishagglund-ship-it chrishagglund-ship-it Awaiting requested review from chrishagglund-ship-it

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArtemIstomin-sm