Merged
Conversation
added pixi.toml with depends as well as build tasks, made CONTRIBUTING.md mostly added stuff regarding dev.
baszalmstra
reviewed
Aug 22, 2023
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
baszalmstra
reviewed
Aug 22, 2023
Collaborator
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
I added some comments. To split sentences over lines in markdown and to also use ~= for the other pixi dependencies. Otherwise looks really good. 👍
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Contributor
Author
|
Thanks for putting those in, hadn't realized the first set of edits you suggested weren't all the instances needing change. |
Contributor
Author
|
Also, is there a preference to squash commits so that the PR has fewer commits where reasonable or is it typically kept as part of the history? |
Collaborator
|
I usually squash and merge when I merge the PR. |
baszalmstra
approved these changes
Aug 23, 2023
Collaborator
|
Thanks @YeungOnion! Fantastic first contribution! |
Closed
Merged
This was referenced Jul 8, 2025
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #282
ran a pixi init and added depends listed in environments.yml.
Needing feedback on
pixi add ...