-
Notifications
You must be signed in to change notification settings - Fork 194
feat: derive default credentials from aws sdk #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
5fbeba5
feat: derive default credentials from aws sdk
baszalmstra 5cc3761
fix: cleanup unused features
baszalmstra 5f09edd
Merge remote-tracking branch 'upstream/main' into rattler-index-defau…
baszalmstra ed87abb
fix: enable using s3 default credentials with s3middelware
baszalmstra f12aca4
upload and fetch too
baszalmstra 487a109
fix: dont error on precondition failure
baszalmstra a3067f8
fix: test compilation and pre-commit
baszalmstra d92dcaa
fix: README
baszalmstra d3357cb
fix: update py-rattler
baszalmstra 32bb14a
test: add minio test
baszalmstra ccfb957
test: use github actions
baszalmstra a4a3f32
test: fix sha
baszalmstra c4ecb71
fix: precommit
baszalmstra 6253387
simpler minio
baszalmstra c6107fc
simpler minio
baszalmstra 1d4314e
dont use pixi
baszalmstra 0e3bf67
fix: cli args
baszalmstra 061f63b
fix: setup role
baszalmstra 903b99a
fix: enable ss3
baszalmstra 413342c
fix: s3
baszalmstra e4c7f00
fix: s3 bucket name
baszalmstra ac3cc09
Merge remote-tracking branch 'upstream/main' into rattler-index-defau…
baszalmstra 476d252
test: use pixi for e2e minio test
baszalmstra 38ec607
fix: globs of rust backend
baszalmstra f58a0ae
fix: locked versions
baszalmstra 4ef1fba
test: enable sccache and fix sha
baszalmstra 5f5b403
fix: aws test script
baszalmstra 6daf82f
fix: broken workflow
baszalmstra a188046
fix: update pixi.lock
baszalmstra 430f8a7
fix: streamline s3 access
baszalmstra 94aa024
fix: pre-commit
baszalmstra 43e687d
cleaned up python bindings
baszalmstra fbbe4e5
fix: cleanup pixi lock
baszalmstra 2bbc46d
fix: update lockfile
baszalmstra 8d32bff
fix: update lockfile
baszalmstra 756812d
Merge remote-tracking branch 'upstream/main' into rattler-index-defau…
baszalmstra c82ba82
Update .github/workflows/e2e-s3-tests.yml
baszalmstra 1c9f3d5
fix: update cargo lockfile
baszalmstra 65ecf07
fix: update lockfile
baszalmstra c836671
fix: linting
baszalmstra 37ad55a
feat: read version from cargo.toml
baszalmstra 866a119
fix: formatting issues
baszalmstra 55feb95
fix: move force_path_style
baszalmstra 2857213
dont use deprecated api
baszalmstra 95a4d64
chore: remove provider name
baszalmstra 3ffe37a
Update crates/rattler_s3/src/lib.rs
baszalmstra c398362
fix: integration test
baszalmstra 4fd1eb9
Merge remote-tracking branch 'upstream/main' into rattler-index-defau…
baszalmstra 2b92d8e
fix: struct ordering
baszalmstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| paths: | ||
| - crates/rattler-bin/** | ||
| - crates/rattler_index/** | ||
| - crates/rattler_upload/** | ||
| - crates/rattler_networking/** | ||
| - .github/workflows/e2e-s3-tests.yml | ||
|
|
||
| name: E2E S3 Tests | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| env: | ||
| RUST_LOG: info | ||
| RUST_BACKTRACE: 1 | ||
| CARGO_TERM_COLOR: always | ||
| DEFAULT_FEATURES: s3 | ||
|
|
||
| jobs: | ||
| e2e-minio-test: | ||
| name: E2E Upload/Index/Download [Minio] | ||
| runs-on: ubuntu-latest | ||
|
|
||
| env: | ||
| # Enable sccache. | ||
| # | ||
| # This environment variable is picked up by pixi build which will then | ||
| # set up the rust build using sccache. | ||
| SCCACHE_GHA_ENABLED: "true" | ||
|
|
||
| steps: | ||
| - name: Checkout source code | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - uses: prefix-dev/setup-pixi@fef5c9568ca6c4ff7707bf840ab0692ba3f08293 # v0.9.0 | ||
| with: | ||
| environments: minio | ||
|
|
||
| - run: pixi run e2e-s3-minio | ||
|
|
||
| # TODO: add cloudflare R2 integration tests here as well | ||
| e2e-aws-s3-test: | ||
|
baszalmstra marked this conversation as resolved.
|
||
| name: E2E Upload/Index/Download [AWS S3] | ||
| runs-on: ubuntu-latest | ||
| # Only run on main branch to avoid creating too many test buckets | ||
| # if: github.ref == 'refs/heads/main' | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
|
|
||
| env: | ||
| # Enable sccache. | ||
| # | ||
| # This environment variable is picked up by pixi build which will then | ||
| # set up the rust build using sccache. | ||
| SCCACHE_GHA_ENABLED: "true" | ||
|
|
||
| # The region to create buckets it. | ||
| AWS_REGION: eu-west-1 | ||
|
|
||
| # The name of the test bucket to create. | ||
| BUCKET: tmp-${{ github.repository_owner }}-${{ github.event.repository.name }}-${{ github.run_id }}-${{ github.run_attempt }} | ||
|
|
||
| steps: | ||
| - name: Checkout source code | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: Configure AWS (OIDC) | ||
| uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4.3.1 | ||
| with: | ||
| aws-region: ${{ env.AWS_REGION }} | ||
| role-to-assume: arn:aws:iam::239378270001:role/conda-rattler-e2e-test | ||
|
|
||
| - uses: prefix-dev/setup-pixi@fef5c9568ca6c4ff7707bf840ab0692ba3f08293 # v0.9.0 | ||
| with: | ||
| environments: s3 | ||
|
|
||
| - run: pixi run e2e-s3-aws | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,6 @@ test-data/channels/conda-forge/ | |
|
|
||
| # Visual studio files | ||
| .vs/ | ||
|
|
||
| # Local environment files | ||
| *.local.* | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [package] | ||
| name = "rattler" | ||
|
|
||
| [package.build.backend] | ||
| name = "pixi-build-rust" | ||
| version = "0.4.*" | ||
| channels = [ | ||
| "https://prefix.dev/pixi-build-backends", | ||
| "https://prefix.dev/conda-forge" | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| use anyhow::Result; | ||
| use miette::IntoDiagnostic; | ||
| use rattler::cli::auth; | ||
|
|
||
| pub type Opt = auth::Args; | ||
|
|
||
| pub async fn auth(opt: Opt) -> Result<()> { | ||
| auth::execute(opt).await.map_err(|e| anyhow::anyhow!(e)) | ||
| pub async fn auth(opt: Opt) -> miette::Result<()> { | ||
| auth::execute(opt).await.into_diagnostic() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you're at it, what about adding cloudflare r2 integration tests as well in this file? @delsner and i definitely wrote some at some point, not sure whether in this repo or in pixi/rattler-build only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was in this repo:
rattler/crates/rattler_networking/tests/s3_integration_test.rs
Lines 18 to 39 in b3eff34