feat: add rattler_config crate (derived from pixi_config)#1389
Merged
wolfv merged 28 commits intoconda:mainfrom Jun 23, 2025
Merged
feat: add rattler_config crate (derived from pixi_config)#1389wolfv merged 28 commits intoconda:mainfrom
rattler_config crate (derived from pixi_config)#1389wolfv merged 28 commits intoconda:mainfrom
Conversation
pavelzw
approved these changes
Jun 16, 2025
Member
pavelzw
left a comment
pavelzw
left a comment
There was a problem hiding this comment.
this looks great! looking forward to using this in other rattler-based tools
Comment on lines
+29
to
+33
| /// The maximum number of concurrent HTTP requests to make. | ||
| // Needing to set this default next to the default of the full struct to avoid serde defaulting | ||
| // to 0 of partial struct was omitted. | ||
| #[serde(default = "default_max_concurrent_downloads")] | ||
| pub downloads: usize, |
Member
There was a problem hiding this comment.
this is great! we can also use this in rattler-index and conda-mirror 🚀
| Ok(()) | ||
| } | ||
| _ => { | ||
| // We don't know this key, but possibly an extension does. |
Member
There was a problem hiding this comment.
Suggested change
| // We don't know this key, but possibly an extension does. | |
| // TODO: We don't know this key, but possibly an extension does. |
Contributor
Author
There was a problem hiding this comment.
I don't think it's a TODO ... we don't know this key, but an extension might
wolfv
changed the title
rattler_config craterattler_config crate (derived from pixi_config)
baszalmstra
requested changes
Jun 19, 2025
Collaborator
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Can we implement Config for all sections like S3Config etc?
baszalmstra
reviewed
Jun 23, 2025
baszalmstra
approved these changes
Jun 23, 2025
Co-authored-by: Bas Zalmstra <4995967+baszalmstra@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description