refactor: move upload from rattler-build to rattler#1386
Merged
Hofer-Julian merged 11 commits intoconda:mainfrom Jul 9, 2025
Merged
refactor: move upload from rattler-build to rattler#1386Hofer-Julian merged 11 commits intoconda:mainfrom
rattler-build to rattler#1386Hofer-Julian merged 11 commits intoconda:mainfrom
Conversation
magentaqin
force-pushed
the
refactor/upload-alignment
branch
2 times, most recently
from
13baea5 to
5a75312
Compare
magentaqin
force-pushed
the
refactor/upload-alignment
branch
from
b36c380 to
a2a01c3
Compare
magentaqin
changed the title
rattler-build to rattlerrattler-build to rattler
Hofer-Julian
reviewed
Jul 9, 2025
Collaborator
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Only had one small comment, apart from that it looks good!
crates/rattler_upload/src/lib.rs
Outdated
| AnacondaData, ArtifactoryData, CondaForgeData, PrefixData, QuetzData, ServerType, UploadOpts, | ||
| }; | ||
|
|
||
| /// Upload. |
Collaborator
There was a problem hiding this comment.
Can you please add a more descriptive docstring here?
Doesn't have to be long, but one word is not enough :)
This was referenced Jul 8, 2025
Merged
Merged
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create new crate
rattler_uploadto solve issue Align pixi upload with rattler-build upload