Skip to content

feat: Support AWS credential manager#1195

Merged
baszalmstra merged 1 commit intoconda:mainfrom
pavelzw:s3-credentials-process
Mar 27, 2025
Merged

feat: Support AWS credential manager#1195
baszalmstra merged 1 commit intoconda:mainfrom
pavelzw:s3-credentials-process

Conversation

@pavelzw
Copy link
Copy Markdown
Member

@pavelzw pavelzw commented Mar 26, 2025

Description

xref prefix-dev/pixi#3438

@mwiebe could you test whether this works for you in pixi? you would need to build pixi with this version of rattler though

@mwiebe
Copy link
Copy Markdown
Contributor

mwiebe commented Mar 26, 2025

I'll give it a try, thanks!

@mwiebe
Copy link
Copy Markdown
Contributor

mwiebe commented Mar 27, 2025

I haven't done very much with rust yet, so not sure how to resolve the errors I'm getting. This is with rustc 1.85.1 (4eb161250 2025-03-15), I'll have to try debugging this later. After updating pixi main to point at this specific git commit, and doing cargo update to try fixing a zip dependency version mismatch, I have it to this error building pixi right now:

error[E0283]: type annotations needed
   --> /home/mw/.cargo/git/checkouts/uv-01b33d56c4bfa7c4/3d94602/crates/uv-client/src/httpcache/mod.rs:866:42
    |
866 |             if stale_amount <= max_stale.into() {
    |                             --           ^^^^
    |                             |
    |                             type must be known at this point
    |
    = note: multiple `impl`s satisfying `u64: PartialOrd<_>` found in the following crates: `core`, `deranged`:
            - impl PartialOrd for u64;
            - impl<MIN, MAX> PartialOrd<deranged::RangedU64<MIN, MAX>> for u64
              where the constant `MIN` has type `u64`, the constant `MAX` has type `u64`;
help: try using a fully qualified path to specify the expected types
    |
866 |             if stale_amount <= <u64_le as Into<T>>::into(max_stale) {
    |                                ++++++++++++++++++++++++++         ~

   Compiling rattler v0.33.3 (https://github.com/pavelzw/rattler.git?rev=8964037309c21aedfbd1c47adee8507e7c2d201e#89640373)

@baszalmstra
Copy link
Copy Markdown
Collaborator

Im going to merge this regardless because it seems like a good change!

@baszalmstra baszalmstra merged commit daa9c5f into conda:main Mar 27, 2025
16 of 17 checks passed
@pavelzw pavelzw deleted the s3-credentials-process branch March 27, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants