Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to poetry 1.8.2 (minimal changes) #636

Closed
wants to merge 1 commit into from

Conversation

romain-intel
Copy link
Contributor

@romain-intel romain-intel commented May 7, 2024

Description

This addresses #613 and updates Poetry to a more modern release (in particular taking in changes around support for Metadata from pypi indices).

This is still a WIP, still missing:

  • proper setup for the environment (needs support for environment markers to properly resolve cross platform)
  • fix the failing tests (hash override) -- I am not sure if this is still relevant as well so not 100% sure how to proceed here.
  • verification of the small code changes that were done to support the new APIs
    Putting it out here so people can take a look and see if there is anything that should be addressed first.

@romain-intel romain-intel requested a review from a team as a code owner May 7, 2024 08:00
Copy link

netlify bot commented May 7, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 4fa0e1e
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6639df87e2a8e30008c82e14
😎 Deploy Preview https://deploy-preview-636--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb
Copy link
Contributor

maresb commented May 7, 2024

Thanks a lot for this!!! Did you use the vendoring tool? If so, are you leaving the source code inside the conda_lock/_vendor directory untouched?

When you're ready for more serious review, would it be possible to put vendoring sync in its own commit?

@romain-intel
Copy link
Contributor Author

I did use vendoring sync. I ran it and fixed up the issues in the other files (the API changes a bit). I think there was one change after the vendoring tool. I'll update the patch to fix it up (it was just hardcoding a version value). But otherwise yes, there is no other change than the ones made by the vendoring tool.

Are you saying you just want the broken commit (ie: it won't work) separately from the fixes so that it is easier to review just the "changes"?

@maresb
Copy link
Contributor

maresb commented May 7, 2024

Are you saying you just want the broken commit (ie: it won't work) separately from the fixes so that it is easier to review just the "changes"?

Exactly, that would be excellent! Probably a more direct way to phrase it is that I'd like a single commit that runs vendoring sync with absolutely no other changes. Please feel free to use git commit --no-verify. That should make it significantly easier for me to review. Thanks!!!

@romain-intel
Copy link
Contributor Author

Closed in favor of #637 which refactors the commits.

@maresb
Copy link
Contributor

maresb commented May 8, 2024

Looks like this wasn't actually closed, but that seems to have been your intention based on the last comment. (I'll leave it to you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants