Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that content hashes are updated for an existing lock file when re-locking #618

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: Ensure that content hashes are updated for an existing lock file when re-locking #618

merged 2 commits into from
Mar 13, 2024

Conversation

jeffseif
Copy link
Contributor

@jeffseif jeffseif commented Mar 13, 2024

Description

This addresses #617 by making the changes described in this section.

Testing

I added an end-to-end test which failed before making the operative change and now passes 🎉 . My only uncertainty is if we feel comfortable hijacking the lock file fakes provided by test-update for this.

CC @maresb for review

@jeffseif jeffseif requested a review from a team as a code owner March 13, 2024 18:47
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 55747d2
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65f1f9b87a18de0008c43ced
😎 Deploy Preview https://deploy-preview-618--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely perfect!!! Thanks for this!

@maresb
Copy link
Contributor

maresb commented Mar 13, 2024

Feel free to ping me once the CI turns green and I'll cut a new release.

@jeffseif
Copy link
Contributor Author

@maresb the CI looks 🟢 to me! Let me know how I can help you to cut a new release.

@maresb maresb merged commit ba0da39 into conda:main Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants