Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation and minor improvement to #581 #586

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

tadeu
Copy link
Contributor

@tadeu tadeu commented Jan 18, 2024

Description

Adding an explanation and a suggested improvement to #581 - it seems important to make it explicit why the thread is there.

@tadeu tadeu requested a review from a team as a code owner January 18, 2024 21:03
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 3a9f3c3
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65a99228aaab3a00082d44d9
😎 Deploy Preview https://deploy-preview-586--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tadeu
Copy link
Contributor Author

tadeu commented Jan 18, 2024

Sorry for not doing this together with the original PR before 😊

@maresb
Copy link
Contributor

maresb commented Jan 18, 2024

Thanks a lot for the comment, I find it very helpful.

Does this use of stdout_thread make any functional difference? Like if p.stdout is true once is it always true?

@tadeu
Copy link
Contributor Author

tadeu commented Jan 18, 2024

Does this use of stdout_thread make any functional difference? Like if p.stdout is true once is it always true?

No functional difference, just maintainability: in case the code is refactored and if p.stdout: is changed to something different, the other if p.stdout: would also need to be changed (and it's a bit far away) - now there's no way to change one condition and "forget" to change the other one.

@maresb maresb merged commit 4bac435 into conda:main Feb 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants