[DOC] Clarify PREFIX usage in environment variables#5065
Merged
kenodegard merged 4 commits intoconda:mainfrom Nov 20, 2023
Merged
[DOC] Clarify PREFIX usage in environment variables#5065kenodegard merged 4 commits intoconda:mainfrom
PREFIX usage in environment variables#5065kenodegard merged 4 commits intoconda:mainfrom
Conversation
Saying `<build prefix>` now implies `BUILD_PREFIX`, which isn't the case. AFAIK these have always been constructed based on `PREFIX`, which is the host environment. Guessing this is just leftover verbiage that needs a refresh.
conda-bot
added
the
cla-signed
This also uses `$PREFIX`. So correct it too.
jakirkham
changed the title
LIBRARY_* & SCRIPT use PREFIXPREFIX usage in environment variables
|
Thanks, John! Line 135 should be changed to refer to "host" prefix. FWIW we found the discrepancy between the docs and the code: conda-forge/cupy-feedstock#228 (comment). |
1 task
kenodegard
approved these changes
Nov 20, 2023
Member
Author
|
Thanks Ken! 🙏 |
Member
Author
|
These changes are in the latest docs |
This was referenced Jan 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saying
<build prefix>now impliesBUILD_PREFIX, which isn't the case. AFAIK these have always been constructed based onPREFIX, which is the host environment. Guessing this is just leftover verbiage that needs a refresh.Also make the same change for
LD_RUN_PATH, which has the same issue.Plus some other lines describing behavior in the prose.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?