Don't set build_id in test phase if --no-build-id is given

[isuruf]

Build work directory is deleted in test phase and it tries to
delete the work dir with id. As a consequence, the test phase
keeps the real work dir and then the next package build breaks
because it tries to apply a patch it was already applied.

cc @gqmelo

xref: conda-forge/conda-smithy#526 (comment)

[msarahan]

Good fix. Is this worth adding a regression test for?

[isuruf]

Sure. You'll have to guide me on it though

[gqmelo]

I created an issue before seeing this PR: #2101

[msarahan]

I'd just start with @gqmelo's nice example:

mkdir -p /tmp/conda_build_id_bug/src
touch /tmp/conda_build_id_bug/src/somefile

echo "
package:
  name: foo
  version: 0.1
source:
  url: https://pypi.io/packages/source/e/exec-wrappers/exec-wrappers-1.0.1.tar.gz
" > /tmp/conda_build_id_bug/meta.yaml

echo "
test -f setup.py
rm setup.py
" > /tmp/conda_build_id_bug/build.sh

conda build --no-build-id /tmp/conda_build_id_bug
conda build --no-build-id /tmp/conda_build_id_bug

translated into a test, I'd move the echo stuff into files, and then instead of the conda build cli commands, I'd instead call api.build:

api.build(recipe_path, set_build_id=False)
api.build(recipe_path, set_build_id=False)

[msarahan]

PS: test_api_build.py might be the right place for this test, but I'm not picky.

[gqmelo]

So this will make the test phase run without the build id, right?
Then before tests the work dir will be removed. But what happens if the package has no tests or they are not run? Wouldn't the next conda build command reuse the dirty work dir?

[msarahan]

I think that without --dirty, the work dir would be cleaned up, but to be honest, I really never use --no-build-id. --no-build-id definitely breaks multiple builds happening at once, but it should still be clean for one build at a time.

[gqmelo]

Also I'd like to add that in the example showed on #2101 if I replace the source url with a local path the work dir is overwritten and the example works

[gqmelo]

Actually my example has no tests at all, so it seems the work dir is really not cleaned up when starting a new build with --no-build-id.

[gqmelo]

So I checked and the work dir with --no-build-id was not being deleted because the cleanup code was taking the work dir modified by the test phase even when there is no test. So this PR also fixes this case.

[msarahan]

PPS: CLI arguments are not always exactly the same as the underlying configuration setting. In particular, I try to keep positive logic in the configuration. Look at https://github.com/conda/conda-build/blob/master/conda_build/config.py#L57 if you want to see what to pass the API call.

[msarahan]

Thanks for the testing @gqmelo and @isuruf for the PR. Merging.

[github-actions]

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!