Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_url CEP #61

Merged
merged 4 commits into from
Jan 22, 2024
Merged

base_url CEP #61

merged 4 commits into from
Jan 22, 2024

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Aug 24, 2023

Allow repodata.json and packages to live in separate places.

cep-base-url.md Outdated Show resolved Hide resolved
cep-base-url.md Outdated Show resolved Hide resolved
@baszalmstra
Copy link
Contributor

I think this is great but what is the usecase for this?

@dholth
Copy link
Contributor Author

dholth commented Aug 24, 2023

Anaconda is experimenting with having a collection of historical repodata.json pointing at the (supposed to be immutable) set of packages. I could have used this while developing jlap, which also had a test proxy to fetch repodata.json more quickly than conda was able to. Someone might also be interested in subsetting repodata.json for policy reasons.

@baszalmstra
Copy link
Contributor

I wonder if conda would work properly if the package keys were sha hashes so that you could point the whole thing at a content-addressed store instead of a server with normal filenames.

I would love to be able to directly use SHA hashes! At prefix we also use a content-addressable store, but we do the conversion on the server side now (which is a bit of a waste). We could also add a URL to each entry with a download URL. Or we can template the base_url to be able to construct a complete URL that might also include something other than the filename. WDYT?

@baszalmstra
Copy link
Contributor

In rattler we do assume that the keys (filenames) are properly formatted and sorted for some speed optimizations so just using sha hashes wouldn't work there.

@baszalmstra
Copy link
Contributor

I implemented this CEP in rattler: conda/rattler#322

@baszalmstra
Copy link
Contributor

Should we maybe start a vote on this CEP?

@jaimergp
Copy link
Contributor

Agreed, this would be awesome to have.

@jezdez
Copy link
Member

jezdez commented Jan 4, 2024

@conda-incubator/steering

This vote falls under the "Enhancement Proposal Approval" policy of the conda governance policy,
please vote and/or comment on this proposal at your earliest convenience.

It needs 60% of the Steering Council to vote yes to pass.

To vote, please leave yes, no or abstain as comments below.

If you have questions concerning the proposal, you may also leave a comment or code review.

This vote will end on 2024-01-18, End of Day, Anywhere on Earth (AoE).

Note: This is an extended voting period to accommodate the start of the year and the complexity of the proposal.

@jezdez jezdez added the vote Voting following governance policy label Jan 4, 2024
@wolfv
Copy link
Contributor

wolfv commented Jan 4, 2024

yes

2 similar comments
@baszalmstra
Copy link
Contributor

yes

@jezdez
Copy link
Member

jezdez commented Jan 4, 2024

yes

@jaimergp
Copy link
Contributor

jaimergp commented Jan 4, 2024

yes

(first repodata_version bump!)

@chenghlee
Copy link

yes

@xhochy
Copy link

xhochy commented Jan 5, 2024

Yes

2 similar comments
@ocefpaf
Copy link

ocefpaf commented Jan 5, 2024

Yes

@msarahan
Copy link
Contributor

msarahan commented Jan 5, 2024

Yes

@wolfv
Copy link
Contributor

wolfv commented Jan 10, 2024

@CJ-Wright @goanpeca @chenghlee @marcelotrevisani @jakirkham @mbargull @kkraus14 this is a reminder to please vote with YES / NO / ABSTAIN on this CEP :)

@marcelotrevisani
Copy link
Member

Yes!

cep-base-url.md Outdated Show resolved Hide resolved
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Co-authored-by: Marcel Bargull <[email protected]>
@kkraus14
Copy link

yes

@mariusvniekerk
Copy link

yes

@CJ-Wright
Copy link

CJ-Wright commented Jan 18, 2024

Yes
I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

@wolfv
Copy link
Contributor

wolfv commented Jan 19, 2024

Vote count:

  • 13 yes
  • 0 abstain
  • 0 no

The steering council consists of 15 people.
That means, 86% have voted, and 100% have voted yes. This CEP is accepted! 🎉

@wolfv wolfv removed the vote Voting following governance policy label Jan 19, 2024
@wolfv
Copy link
Contributor

wolfv commented Jan 22, 2024

@dholth any last changes? Otherwise I or @jezdez should probably push the CEP (cep-15.md) to it's final name and merge to the repo.

@dholth
Copy link
Contributor Author

dholth commented Jan 22, 2024

LGTM, merge it.

@wolfv wolfv merged commit a080726 into conda:main Jan 22, 2024
@wolfv
Copy link
Contributor

wolfv commented Jan 22, 2024

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.