Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address mamba v2 incompatibilities #368

Merged
merged 38 commits into from
Oct 3, 2024
Merged

Address mamba v2 incompatibilities #368

merged 38 commits into from
Oct 3, 2024

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Oct 1, 2024

Closes #366

Mamba v2 compatibility needs:

  • Setting MAMBA_ROOT_PREFIX to the base env location.
  • Using mamba env create instead of mamba env update if the target env doesn't exist. conda does create the target env with env update if it didn't exist 🤷
  • On Unix, symlink bin/mamba to condabin so it can be found in PATH later (same as Put mamba under condabin/ too conda-forge/mamba-feedstock#251).
  • On Windows, write the condabin/mamba.bat file from mamba 1.x, adjusting the path to mamba.exe as necessary.

@jaimergp jaimergp requested a review from a team as a code owner October 1, 2024 17:44
@jaimergp
Copy link
Member Author

jaimergp commented Oct 1, 2024

Ok, this seems to work mostly in Unix, but mamba v2 gets "stuck" for Windows in this part:

...
  Linking requests-2.32.3-pyhd8ed1ab_0
  Linking jsonschema-4.23.0-pyhd8ed1ab_0
  Linking requests-toolbelt-1.0.0-pyhd8ed1ab_0
  Linking nbformat-5.10.4-pyhd8ed1ab_0
  Linking anaconda-client-1.12.3-pyhd8ed1ab_1
  Warning: warning  libmamba draining failed An existing connection was forcibly closed by the remote host.
  
  warning  libmamba draining failed An existing connection was forcibly closed by the remote host.

@jaimergp
Copy link
Member Author

jaimergp commented Oct 3, 2024

Disabling PYC compilation unlocks the hang, but then it hangs again during the pip installs. Seems that in both cases a hung subprocess on Windows is involved. I guess these code blocks:

@jaimergp
Copy link
Member Author

jaimergp commented Oct 3, 2024

@conda-incubator/setup-miniconda, ready for review!

@jaimergp jaimergp merged commit 899c78d into main Oct 3, 2024
63 checks passed
@jezdez jezdez deleted the fix-mamba-v2 branch October 4, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mamba example 6 seems to be failing
2 participants