Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gpu support #84

Merged
merged 9 commits into from
Feb 15, 2022
Merged

add gpu support #84

merged 9 commits into from
Feb 15, 2022

Conversation

izahn
Copy link
Contributor

@izahn izahn commented Feb 13, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #26

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me how we get the cpu package to be the default on installation?

recipe/build.sh Outdated Show resolved Hide resolved
@izahn
Copy link
Contributor Author

izahn commented Feb 14, 2022

I think this is basically working now, but I could use some help making sure the variants are coordinated correctly. If you can take a look at the build strings and mutex packages and see if it makes sense that would be great!

Copy link

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see progress on GPU build. I'm not familiar with conda packaging, but feel free to ping me if there's anything I can help.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks Ista! 😀

Also cc-ing @hcho3

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@izahn
Copy link
Contributor Author

izahn commented Feb 15, 2022

Can you remind me how we get the cpu package to be the default on installation?

From what I've been able to gather this is done by depending on __cuda which will cause the cpu version to be selected by default on systems without a suitable gpu. I added this in 7742987 that should do the trick.

@izahn
Copy link
Contributor Author

izahn commented Feb 15, 2022

OK I've cleaned everything up and done my best with mutex and meta packages, and the build strings should all make sense. This is ready for review.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izahn !

@xhochy xhochy merged commit 24a91ca into conda-forge:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xgboost GPU support
5 participants