Skip to content

Drop --configure-args - #178

Merged
chyunsu3 merged 3 commits into
conda-forge:mainfrom
chyunsu3:remove_macos_patch
Jul 29, 2024
Merged

chyunsu3 merged 3 commits into
conda-forge:mainfrom
chyunsu3:remove_macos_patch

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Jul 29, 2024 •

Copy link
Copy Markdown
Contributor

Closes #176
Closes #175

Checklist

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@chyunsu3 chyunsu3 changed the title Drop --configure-args Drop 0002 patch Jul 29, 2024
@chyunsu3

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@github-actions

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10152273467.

This reverts commit 4553232.
@chyunsu3 chyunsu3 changed the title Drop 0002 patch Drop --configure-args Jul 29, 2024
@chyunsu3

Copy link
Copy Markdown
Contributor Author

It turns out that the 0002 patch is necessary: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=990207&view=logs&j=9c5ef928-2cd6-52e5-dbe6-9d173a7d951b&t=20c71c51-4b27-578b-485d-06ade2de1d00.

I will try to remove the --configure-args and see if it works.

@chyunsu3
chyunsu3 merged commit 8c5f949 into conda-forge:main Jul 29, 2024
@chyunsu3
chyunsu3 deleted the remove_macos_patch branch July 29, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In R UNIX build, drop unused command/comment about Makevars.win? Revisit macOS patch to use latest libcxx (aka 0002)

1 participant