don't unset some VS-related variables after activation

[h-vetinari]

In the context of #94, we need to publish new builds, because conda-forge/admin-requests#1460 isn't taking effect due to conda-forge/conda-forge-repodata-patches-feedstock#986.

I started out with wanting to revert #93, but then noticed that one of the changes of that PR was that we're unsetting VSINSTALLDIR, which looks like it would exactly explain the sort of "forgot the path to MVSC toolchain" issues we're seeing in #94.

So reinstate variables that are very likely related to the issues there. If that still doesn't work out, we can revert #93

Fixes #94
Fixes #91

[h-vetinari]

@isuruf, if you are online, PTAL.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

• ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
• ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16362318596. Examine the logs at this URL for more detail.}

[isuruf]

Let's revert the whole PR and get back to this after all the anaconda.org issues and cmake 4 issues die down

[h-vetinari]

Let's revert the whole PR and get back to this after all the anaconda.org issues and cmake 4 issues die down

Felt like reinstating VSINSTALLDIR would have been worth a shot, but here you go: #96

[h-vetinari]

Let's [...] get back to this after all the anaconda.org issues and cmake 4 issues die down

That should be the case now.

[h-vetinari]

Ping @isuruf

[h-vetinari]

This runs into too-long filenames

Creating archive: D:\a\1\a\conda-forge/vc-feedstock_conda_artifacts_20250609.1.1_win_64_cl_version19.29.30139cross_target_platformwin-64runtime_version14.29.30139sha256296F96CD102250636BCD23AB6E6CF70935337B1BBB3507FE8521D8D9CFAA932Fupdate_version11uuidb929b7fe-5c89-4553-9abe-6324631dcc3avcver14.2vsyear2019.zip

Add new data to archive: 8 folders, 17 files, 1018128 bytes (995 KiB)


Error:
cannot open file
D:\a\1\a\conda-forge/vc-feedstock_conda_artifacts_20250609.1.1_win_64_cl_version19.29.30139cross_target_platformwin-64runtime_version14.29.30139sha256296F96CD102250636BCD23AB6E6CF70935337B1BBB3507FE8521D8D9CFAA932Fupdate_version11uuidb929b7fe-5c89-4553-9abe-6324631dcc3avcver14.2vsyear2019.zip
The filename, directory name, or volume label syntax is incorrect.
##[error]Cmd.exe exited with code '1'.

I'm reviving an old smithy PR that fixes this (conda-forge/conda-smithy#2233).

[h-vetinari]

Ping @isuruf

[h-vetinari]

Ping @isuruf

[isuruf]

It looks like CMAKE_GEN is being by used conda-forge recipes even though it's not supposed to be.

[h-vetinari]

It looks like that's limited to 3 feedstocks. Sounds like we could just fix those?

[isuruf]

Yeah, let's fix those first. I'd hate to break scikit-build-core package.since it's used in an activate script.

[h-vetinari]

@isuruf, now that conda-forge/scikit-build-core-feedstock#67 is merged, this should be good to go?

[h-vetinari]

Ping @isuruf

[h-vetinari]

@conda-forge/core I'm not able to get a response here, and willing to join as maintainer - could someone please merge? I have the second-most commits on this feedstock, so arguably already de facto a maintainer anyway. :)

[h-vetinari]

Sigh, this still leads to breakage it seems (at least it looks very similar to #94), e.g. in conda-forge/mimalloc-feedstock#39. I'll revert this yet again in #99

 │ │ -- Check for working C compiler: %BUILD_PREFIX%/Library/bin/clang.exe - broken
 │ │   The C compiler
 │ │     "%BUILD_PREFIX%/Library/bin/clang.exe"
 │ │   is not able to compile a simple test program.
 │ │   It fails with the following output:
 │ │     Change Dir: '%SRC_DIR%/out/release/CMakeFiles/CMakeScratch/TryCompile-0ghiu9'
 │ │     
 │ │     Run Build Command(s): %BUILD_PREFIX%/Library/bin/ninja.exe -v cmTC_1bad2
 │ │     [1/2] %BUILD_PREFIX%\Library\bin\clang.exe   -march=nocona -mtune=haswell -ftree-vectorize -fstack-protector-strong -O2 -ffunction-sections -pipe -D_CRT_SECURE_NO_WARNINGS -nostdlib -fms-runtime-lib=dll -fuse-ld=lld -fno-aligned-allocation  -O0 -g -Xclang -gcodeview -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd -MD -MT CMakeFiles/cmTC_1bad2.dir/testCCompiler.c.obj -MF CMakeFiles\cmTC_1bad2.dir\testCCompiler.c.obj.d -o CMakeFiles/cmTC_1bad2.dir/testCCompiler.c.obj -c %SRC_DIR%/out/release/CMakeFiles/CMakeScratch/TryCompile-0ghiu9/testCCompiler.c
 │ │     [2/2] C:\Windows\system32\cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\clang.exe -nostartfiles -nostdlib -march=nocona -mtune=haswell -ftree-vectorize -fstack-protector-strong -O2 -ffunction-sections -pipe -D_CRT_SECURE_NO_WARNINGS -nostdlib -fms-runtime-lib=dll -fuse-ld=lld -fno-aligned-allocation  -O0 -g -Xclang -gcodeview -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd -nostdlib -Wl,-defaultlib:%BUILD_PREFIX%/lib/clang/19/lib/windows/clang_rt.builtins-x86_64.lib  -Xlinker /subsystem:console -fuse-ld=lld-link CMakeFiles/cmTC_1bad2.dir/testCCompiler.c.obj -o cmTC_1bad2.exe -Xlinker /MANIFEST:EMBED -Xlinker /implib:cmTC_1bad2.lib -Xlinker /pdb:cmTC_1bad2.pdb -Xlinker /version:0.0   -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 -loldnames  && cd ."
 │ │     FAILED: [code=1] cmTC_1bad2.exe 
 │ │ -- Configuring incomplete, errors occurred!
 │ │     C:\Windows\system32\cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\clang.exe -nostartfiles -nostdlib -march=nocona -mtune=haswell -ftree-vectorize -fstack-protector-strong -O2 -ffunction-sections -pipe -D_CRT_SECURE_NO_WARNINGS -nostdlib -fms-runtime-lib=dll -fuse-ld=lld -fno-aligned-allocation  -O0 -g -Xclang -gcodeview -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd -nostdlib -Wl,-defaultlib:%BUILD_PREFIX%/lib/clang/19/lib/windows/clang_rt.builtins-x86_64.lib  -Xlinker /subsystem:console -fuse-ld=lld-link CMakeFiles/cmTC_1bad2.dir/testCCompiler.c.obj -o cmTC_1bad2.exe -Xlinker /MANIFEST:EMBED -Xlinker /implib:cmTC_1bad2.lib -Xlinker /pdb:cmTC_1bad2.pdb -Xlinker /version:0.0   -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 -loldnames  && cd ."
 │ │     lld-link: error: could not open 'kernel32.lib': no such file or directory
 │ │     lld-link: error: could not open 'user32.lib': no such file or directory
 │ │     lld-link: error: could not open 'gdi32.lib': no such file or directory
 │ │     lld-link: error: could not open 'winspool.lib': no such file or directory
 │ │     lld-link: error: could not open 'shell32.lib': no such file or directory
 │ │     lld-link: error: could not open 'ole32.lib': no such file or directory
 │ │     lld-link: error: could not open 'oleaut32.lib': no such file or directory
 │ │     lld-link: error: could not open 'uuid.lib': no such file or directory
 │ │     lld-link: error: could not open 'comdlg32.lib': no such file or directory
 │ │     lld-link: error: could not open 'advapi32.lib': no such file or directory
 │ │     lld-link: error: could not open 'oldnames.lib': no such file or directory
 │ │     lld-link: error: could not open 'msvcrt.lib': no such file or directory
 │ │     lld-link: error: could not open 'msvcrtd.lib': no such file or directory
 │ │     clang: error: linker command failed with exit code 1 (use -v to see invocation)
 │ │     ninja: build stopped: subcommand failed.