Skip to content

triton v3.3.1#51

Merged
h-vetinari merged 4 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:3.3.1_h62322f
May 31, 2025
Merged

triton v3.3.1#51
h-vetinari merged 4 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:3.3.1_h62322f

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented May 31, 2025

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/15358009447 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari marked this pull request as draft May 31, 2025 00:54
@h-vetinari
Copy link
Copy Markdown
Member

h-vetinari commented May 31, 2025

Need to investigate the right commit hashes, and whether that's compatible with 3.3.0 (anyone reading this should feel free to do this, not sure when I get around to it)

@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented May 31, 2025

Need to investigate the right commit hashes, and whether that's compatible with 3.3.0 (anyone reading this should feel free to do this, not sure when I get around to it)

We now have a tag!

@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented May 31, 2025

(read: I'm working on it)

@mgorny mgorny marked this pull request as ready for review May 31, 2025 05:28
This reverts commit 703f27d.
Accidentally looked at the pin on main rather than the release tag.
@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented May 31, 2025

whether that's compatible with 3.3.0

The code changes seem to boil down to:

diff --git a/lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp b/lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp
index 5b26d6e3b..cd3fd737f 100644
--- a/lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp
+++ b/lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp
@@ -38,6 +38,8 @@ static int getMMAVersionSafe(int computeCapability, DotOp op) {
     versionsSupported = {3, 2};
   } else if (computeCapability < 110) {
     versionsSupported = {5, 2};
+  } else if (computeCapability < 130) {
+    versionsSupported = {2};
   } else {
     assert(false && "computeCapability not supported");
   }

so I think it should be safe :-).

Copy link
Copy Markdown
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-vetinari h-vetinari merged commit 3fbccc9 into conda-forge:main May 31, 2025
13 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 3.3.1_h62322f branch May 31, 2025 21:49
@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented Jun 1, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants