reactivate trilinos recipe#56
Conversation
…nda-forge-pinning 2025.07.25.22.53.01
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16534144520. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2025.07.25.22.53.01
Add make
|
Awaiting merge of updated kokkos-kernels feedstock, as macOS packages require dependency update |
|
@conda-forge-admin, please restart ci |
Add kokkos and kokkos-kernels to host and run to grab newer versions
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16735958441. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16881216746. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Add maintainer documentation flag regarding newer SDKs
|
@conda-forge/core ready to go! (ref #54). Not the most recent release of trilinos, but there are a lot of deprecation notices in v16 and I figured it would be better to get a more recent version than is on conda-forge out sooner. I'll work to get it current in the next few months. |
h-vetinari
left a comment
There was a problem hiding this comment.
This looks pretty good, thanks for stepping up!
| - kokkos ==4.2.01 | ||
| - kokkos-kernels ==4.2.01 | ||
| run_constrained: | ||
| - pytrilinos ==999999999 |
There was a problem hiding this comment.
are you planning to update pytrilinos as well? See conda-forge/pytrilinos-feedstock#4 and discussion here
There was a problem hiding this comment.
pytrilinos is one of the packages that's being deprecated for trilinos>16.1, in favor of pytrilinos2.
In principle I'm not opposed to doing so, but I probably won't get to it for another month or so, but curious if the upgrade to pytrilinos2 should just be done in the existing feedstock, or as a new recipe.
That said, there are multiple other packages that could be split this way from trilinos (e.g., Kokkos and Kokkos-kernels already have been, SEACAS could be (e.g., conda-forge/staged-recipes#30623) etc. I'm wondering if there is a preference to try to split out all of the potential TPLs from "meta-packages" like trilinos as their own recipe and just link to the other TPLs, or to have them more self contained? If the former, I could start to pick at this in spare time over the next several months.
There was a problem hiding this comment.
In general, we prefer to avoid monolithic monster packages, but rather splitting things up into relevant stand-alone components, at least where those have other uses/users (e.g. like kokkos).
pytrilinos is one of the packages that's being deprecated for trilinos>16.1, in favor of pytrilinos2.
I mean, is it just the name of the PyPI package or the python import name that changed? We could still provide a current pytrilinos on top of trilinos, and then add a "compatibility wrapper" for those people that somehow expect pytrilinos2, e.g.
outputs:
- name: pytrilinos
# [... the actual build ...]
# compat wrapper for new package name
- name: pytrilinos2
requirements:
host:
- {{ pin_subpackage("pytrilinos") }}
run:
- {{ pin_subpackage("pytrilinos") }}There was a problem hiding this comment.
I'm not sure of the answer to your question, I'll have to look into it. The compatibility wrapper is a nice idea though, thanks!
| - kokkos ==4.2.01 | ||
| - kokkos-kernels ==4.2.01 |
There was a problem hiding this comment.
Could you add a comment why this needs to be pinned so tightly?
There was a problem hiding this comment.
The short answer is that the build with both packages constrained to >=4.2.0, <5 failed because the version appears to be pinned pretty tightly within Trilinos cmake.
The previous recipe version built Kokkos and kokkos-kernels as part of trilinos, and I had been thinking it would be more space efficient to just link them but hadn't realized beforehand they were so tightly pinned within trilinos.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)