Skip to content

Build Torchsparse 2.0.0 and Rebuild for pytorch1.13.1#29

Open
regro-cf-autotick-bot wants to merge 24 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-pytorch21-0-1_hbcd704
Open

Build Torchsparse 2.0.0 and Rebuild for pytorch1.13.1#29
regro-cf-autotick-bot wants to merge 24 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-pytorch21-0-1_hbcd704

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update pytorch21.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6853355102, please use this URL for debugging.

@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title Rebuild for pytorch21 Build Torchsparse 2.0.0 and Rebuild for pytorch21 Nov 27, 2023
Comment thread recipe/meta.yaml Outdated
run_exports:
# ensure matching proc-type
- torchvision =*=*_{{ torch_proc_type }}
- torchsparse =*=*_{{ torch_proc_type }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm....

@hmaarrfk

hmaarrfk commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 4 commits March 7, 2024 23:33
@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk

hmaarrfk commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits March 8, 2024 03:04
Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml
# The first gets filled in by the global pinnings
# The second gets the processor type
- pytorch
- pytorch 2.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pytorch 2.0
# It seems that torchsparse is only built and tested with one or
# two versions of pytorch in mind. keep this in sync with upstream
- pytorch 1.3.1

Comment thread recipe/meta.yaml Outdated

@hmaarrfk hmaarrfk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update pin to 1.13.1

@hmaarrfk hmaarrfk changed the title Build Torchsparse 2.0.0 and Rebuild for pytorch21 Build Torchsparse 2.0.0 and Rebuild for pytorch1.13.1 Mar 8, 2024
@hmaarrfk

hmaarrfk commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits March 8, 2024 13:44
@hmaarrfk

hmaarrfk commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

@conda-forge-admin please rerender

@fabioruetz

Copy link
Copy Markdown

@conda-forge-admin please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • ❌ You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package torchsparse using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.
  • ℹ️ top-level output has some malformed specs:
  • In section build: pytorch =pytorch=cuda*
  • In section host: pytorch =*=cuda*
  • In section run_constrained: pytorch =*=cuda*
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.
  • ℹ️ In conda-forge.yml: $.test_on_native_only = True.

    'Test On Native Only' is deprecated.
    This was used for disabling testing for cross-compiling.

    This has been deprecated in favor of the top-level `test` field.
    It is now mapped to `test: native_and_emulated`.
    
    Schema
    {
      "anyOf": [
        {
          "type": "boolean"
        },
        {
          "type": "null"
        }
      ],
      "default": false,
      "deprecated": true,
      "title": "Test On Native Only"
    }

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15747583974. Examine the logs at this URL for more detail.

@h-vetinari

Copy link
Copy Markdown
Member

@fabioruetz, torchsparse 2.0 is not compatible with newer pytorch (which itself has only been rebuilt for newer abseil, grpc, etc.). You should try to ensure that upstream is compatible with pytorch 2.0 (if that didn't happen already), and that they tag a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants