Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update aws_sdk_cpp111210.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7037030619, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Comment on lines 68 to 70
# fails because fsspec is not available (AWS S3 stuff)
{% set tests_to_skip = tests_to_skip + " or test_fsspec_io_iterdatapipe" %}
{% set tests_to_skip = tests_to_skip + " or test_s3_io_iterdatapipe" %}
Copy link
Member

@weiji14 weiji14 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuing on from #18 (comment), it seems like these tests are still failing on Linux (but not on macOS), even with a new AWS SDK version. I've tested the torchdata-0.7.1-py311ha8bf654_0 build from #18 locally to access s3 files, and it works fine to list/download files from an s3 bucket, so not sure why these tests are failing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to revert that last commit for now (or rebase it out). It could be a lot of things (e.g. around the call to the AWS cli and its expectations), but IMO it's not necessary to investigate at the moment.

Copy link
Member

@weiji14 weiji14 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I've reverted the change, and can merge it once the CI passes.

@Tobias-Fischer Tobias-Fischer merged commit 8cea82f into conda-forge:main Nov 30, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-aws_sdk_cpp111210-0-1_hb24df7 branch November 30, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants