Skip to content

Rebuild for pytorch21 + bump to 0.7.1 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiji14 merged 11 commits into from
Nov 27, 2023
Merged

Rebuild for pytorch21 + bump to 0.7.1 #18

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe5057e
Rebuild for pytorch21
regro-cf-autotick-bot Nov 13, 2023
3d4b9b9
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.28.0, and co…
regro-cf-autotick-bot Nov 13, 2023
c143adb
Bump to 0.7.0
Tobias-Fischer Nov 13, 2023
4be341a
Fixup pip check
Tobias-Fischer Nov 13, 2023
8df3911
Disable AWS tests
Tobias-Fischer Nov 13, 2023
7a1aa99
Bump to 0.7.1
Tobias-Fischer Nov 16, 2023
aa22267
Set upper pin on cryptography to 40.0.2 in test.requires
weiji14 Nov 24, 2023
dca136c
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.0, and co…
Nov 24, 2023
ddb453e
Disable test_early_exit_ctx_* which might timeout after 6 hours
weiji14 Nov 24, 2023
089dc2b
Try re-enabling fsspec and s3 tests
weiji14 Nov 26, 2023
fe77568
Revert "Try re-enabling fsspec and s3 tests"
weiji14 Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ requirements:
- requests
- urllib3 >=1.25
- pytorch
- cryptography <40.0.2,>=3.3.2
Copy link
Member

@h-vetinari h-vetinari Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like capping cryptography, that's an extremely low-level but highly security-critical package, with a very conservative evolution speed. My preference would be to patch the upper bound completely.

And if there's a good argument for not doing that, then at least please order this sensibly, i.e.

- cryptography >=3.3.2,<40.0.2

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The awscli has the cap, not torchdata directly. The awscli stuff doesn't do a pip check so this is not caught there.

Copy link
Member

@weiji14 weiji14 Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this cryptography pin be placed under test.requires instead of being listed as a runtime dependency actually?

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiji14 - I am not very familiar with torchdata. Feel free to take over this PR if you have any ideas how to push it forward.

Copy link
Member

@weiji14 weiji14 Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me open another PR to add myself to the recipe maintainer list (#21).


test:
imports:
Expand Down