Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows [de]activate scripts' locations (old) #12

Closed
wants to merge 2 commits into from
Closed

Fix Windows [de]activate scripts' locations (old) #12

wants to merge 2 commits into from

Conversation

jakirkham
Copy link
Member

Seems these are suppose to be in %PREFIX% not %LIBRARY_PREFIX% on Windows. This relocates them. However, we didn't use them to do anything before or now; hence, the minor version bump instead of major. Maybe @msarahan can confirm if this is correct.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan
Copy link
Member

msarahan commented Jul 7, 2016

LGTM, without testing.

@jakirkham jakirkham changed the title WIP: Fix Windows [de]activate scripts' locations Fix Windows [de]activate scripts' locations Jul 7, 2016
@jakirkham
Copy link
Member Author

I think this needs the same fix that ca-certificates needs. Namely this fix ( conda/conda-build#1107 ).

@jakirkham jakirkham closed this Jan 5, 2017
@jakirkham jakirkham reopened this Jan 5, 2017
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mbargull
Copy link
Member

mbargull commented Nov 7, 2017

I just noticed the same and was about to make a PR for this 😉. Those changes also LGTM

@jakirkham jakirkham changed the title Fix Windows [de]activate scripts' locations Fix Windows [de]activate scripts' locations (old) Nov 7, 2017
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member Author

Thanks for the reminder @mbargull. Had forgotten about this one. Refreshed and opened as a new PR. ( #33 )

@jakirkham jakirkham closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants