Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test paraview updates #47

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

psavery
Copy link
Contributor

@psavery psavery commented Sep 16, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This is to ensure the new ParaView updates branch of tomviz
(OpenChemistry/tomviz#2180) is working in the conda-forge build.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery force-pushed the test-paraview-updates branch from 2c5fb94 to 1307b9a Compare September 16, 2022 21:08
ParaView now uses 1.13.1

Signed-off-by: Patrick Avery <[email protected]>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: build: hdf5==1.13.1 must contain a space between the name and the pin, i.e. hdf5 ==1.13.1
  • requirements: host: hdf5==1.13.1 must contain a space between the name and the pin, i.e. hdf5 ==1.13.1

It needs to match the one that ParaView is using.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery force-pushed the test-paraview-updates branch from 22f1070 to 3996528 Compare September 17, 2022 01:55
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

HDF5 13 is not yet available on conda-forge. Maybe 1.12.2 is new
enough to not clash with the one in ParaView.

Signed-off-by: Patrick Avery <[email protected]>
@hmaarrfk
Copy link

Were you interested in helping with these feedstock? it seems to need some help

The "official" way to update the HDF version would be to pull in the migration:
https://github.com/conda-forge/tomviz-feedstock/pull/48/files#diff-428f09a3f9df8d5a3a6bb89d99eca5b4341773a44b238fa55a20134608ca3edb

copy the file to the same location and rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants