-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include itk-elastix in tomviz packaging #19
base: main
Are you sure you want to change the base?
Conversation
We want to include `itk-elastix` as a dependency to tomviz, but it is not available on conda-forge. However, it is available on pip, it is small, and it was designed to work in conda environments (similar to ITK). Thus, we can `pip install` it and include it in our tomviz package. Signed-off-by: Patrick Avery <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.01.05.14.36.24
Signed-off-by: Patrick Avery <[email protected]>
This is to try to fix some errors, such as the following: ``` warning: libGLdispatch.so.0, needed by /usr/lib64/libGLX.so, not found /usr/lib64/libGLX.so: undefined reference to `__glDispatchLoseCurrent' ``` Signed-off-by: Patrick Avery <[email protected]>
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.01.05.14.36.24
Thanks for the contribution, @psavery! I am not sure about conda-forge's policy on installing packages from PyPI, but we could ask. How hard would it be to package the needed code in conda-forge? Does it require any compilation? |
@mrakitin We are following a similar approach that is used in the itk conda forage feedstock, so figure it would be ok? We don't fancy takin on creating a conda package for |
ITK compiles the binaries in their wheels in a way so that they are compatible in conda environments. As @cjh1 mentioned, the ITK feedstock actually just installs their pypi wheels in their feedstock. You can see that here. |
From the failed building log for Linux it looks like conda can't find the package:
Do you want https://anaconda.org/conda-forge/libglvnd-glx-cos7-x86_64 instead? I think it's related to the recent CF switch to the CentOS 7 (see conda-forge/conda-forge.github.io#1436). |
Hi Maksim, I think that sounds good to us! I don't think we are intentionally using CentOS 6. Could you help us use 7 instead? We added
We searched for Thank you! |
Actually, the CentOS7 is already used here after rerendering, see https://github.com/conda-forge/tomviz-feedstock/pull/19/files#diff-6608a67cc3923d5132134d7371ec0fb28a30decb656682b28c86c49acab8371bR16. You may try to roll back to CentOS6 (the previous value in that diff, done via the Otherwise, I suspect the metapackage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package has to be submitted to staged-recipes. It cannot be installed via pip in this PR.
This feedstock needs to be fixed as well. |
We want to include
itk-elastix
as a dependency to tomviz, but it isnot available on conda-forge.
However, it is available on pip, it is small, and it was designed to
work in conda environments (similar to ITK). Thus, we can
pip install
it and include it in our tomviz package.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)