Add eccodes python interface

[StephanSiemen]

This will package the Python 2 and 3 interfaces to eccodes based on CFII from PyPi

Hi @conda-forge/help-python, we finally manage to package the proper Python interface to eccodes here. This takes the version independent implementation from PyPi. As soon this package is accepted, we can add this as dependency to 'eccodes' and can retire 'python-eccodes' for good :-)

Thanks for your help!

Checklist

• [x ] License file is packaged (see here for an example)
• [x ] Source is from official source
• [ x] Package does not vend other packages
• [x ] Build number is 0
• [x ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
• [x ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/eccodes-python) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/eccodes-python:

• license_file entry is missing, but is expected.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/eccodes-python) and found it was in an excellent condition.

[chrisburr]

Is this vending gribapi?

[chrisburr]

Assuming eccodes is the authoritative source of gribapi, I think these are the changes that are needed.

[StephanSiemen]

Is this vending gribapi?

'eccodes' supersedes 'grib_api'. The library handles now also BUFR and not only GRIB data, therefore it was renamed. grib_api is now frozen. This interface would actually work with grib_api, but all BUFR related commands would fail.

[StephanSiemen]

@chrisburr the pr is blocked because of an outstanding change request by you. I have difficulties to see what it refers to. Any help is appreciated. Thanks

[chrisburr]

That's just the way GitHub shows that I had previously requested changes. It doesn't block this from being merged by anyone else on the staged-recipes team, just encourages them to check the comments to see if it's been fixed. (In this case it was the licence)

One last question, would it be better to update https://github.com/conda-forge/python-eccodes-feedstock/ instead of making a new feedstock?

cc @conda-forge/python-eccodes

[StephanSiemen]

That's just the way GitHub shows that I had previously requested changes. It doesn't block this from being merged by anyone else on the staged-recipes team, just encourages them to check the comments to see if it's been fixed. (In this case it was the licence)

One last question, would it be better to update https://github.com/conda-forge/python-eccodes-feedstock/ instead of making a new feedstock?

cc @conda-forge/python-eccodes

Thanks @chrisburr for your help. 'python-eccodes' as is currently setup is the building of eccodes library and the python interface through the old swig setup which only works for Python2. Users asked us not to touch this setup to avoid changes to their dependencies (we anyway have no write access) and instead have a new clean setup where the library and python interface are separated. We were suggested to use the same name as on PyPi to reduce confusion. At SciPy I was told 'python-eccodes' as an Python2-only package would be frozen at the end of year and then this would be the one everyone would use in future. I agree, with hindsight this is not the ideal road to take ...

@chrisburr this is really not a bad question to ask, and if anyone from @conda-forge/python-eccodes has a better suggestion, we are very happy to listen. Now is the time ;-)

[kmuehlbauer]

As soon this package is accepted, we can add this as dependency to 'eccodes' and can retire 'python-eccodes' for good :-)

@StephanSiemen I would agree with the latter but I do not understand the first. How should this new package eccodes-python be added to eccodes?

[kmuehlbauer]

@chrisburr The thing was talked about in conda-forge/python-eccodes-feedstock#49 and the new bindings added in conda-forge/python-eccodes-feedstock#48 with efforts from @beckermr.

For now we can conda install the new eccodes-python (from https://github.com/ecmwf/eccodes-python) as python-eccodes. The naming scheme is still an issue and maybe it was not a good idea to name it python-eccodes back then (#742 and #750) (my bad, I choose it having python-ecmwf_grib as guideline).

Now I'm not really sure, if I would still argue like in my comment here.

Maybe we could go the gdal way, having multiple outputs from one feedstock. @ocefpaf what does CF core suggest in those cases.

[ocefpaf]

Maybe we could go the gdal way, having multiple outputs from one feedstock. @ocefpaf what does CF core suggest in those cases.

This is probably better. I cannot help at the moment (day job travel and some deadlines until the end of the year). However, if someone wants to tackle this feel free to ping me for a review. The gdal and matplotlib feedstocks are good examples on how to do this.

[kynan]

Note that this file name is relative to the package root, not relative to the recipe. It is therefore not necessary to include the license with the recipe. This should be LICENSE to match the file name in the source dist.

[stale]

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

[stale]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!