-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readd bob.ip.flandmark [skip appveyor] #751
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I think this will be fixed once we have |
This is failing for good reasons! Setuptools is a runtime dependency of |
Was just about to ask that. Why is that the case? |
Because it uses |
Sure, I'm just wondering what it does with it. |
I remember in the early days, I had |
when I was doing the first |
|
Agreed. That makes sense. Maybe we can do that first and come back here afterwards. |
ok all green now. Could you please merge this? |
export MACOSX_DEPLOYMENT_TARGET=10.9 | ||
export CFLAGS="${CFLAGS} -pthread" | ||
export LDFLAGS="${LDFLAGS} -lpthread" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be replaced. Please see this PR ( conda-forge/thrift-cpp-feedstock#4 ) for how to change this.
@jakirkham adding |
Could you please try pinning |
@msarahan, do you have any idea why this would happen? |
Sure, but please don't cancel circle CI if possible. |
No worries. Not canceling anything. |
@jakirkham this is finally building. Can we merge it now please? |
No description provided.