Add conda #656

jakirkham · 2016-05-23T04:25:58Z

Adds recipes that either I wrote or used conda skeleton pypi to generate and then modified. Having some issue getting the conda recipe to build. The rest seem to be doing ok. Maybe we can break out the working ones and merge them first.

@msarahan, I have added you and myself as maintainers on all of these. Please let me know if that is ok. I don't feel a strong need to be a maintainer here, but I feel my handle should be on them as I wrote them.

@pelson, seemed like you were interested in seeing this happen. This gets the process started at least. If the going gets slow, feel free to take the reigns.

conda-forge-linter · 2016-05-23T04:29:30Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda, recipes/conda-env, recipes/pycosat, recipes/requests) and found it was in an excellent condition.

jakirkham · 2016-05-23T04:46:08Z

Broke out the dependencies in this PR ( #657 ) so we can sort them out and get them in first.

pelson · 2016-05-25T06:36:16Z

recipes/conda/meta.yaml

+  url: https://github.com/conda/conda/archive/{{ version }}.tar.gz
+  sha256: 4ca7ec875de13519aeb3eebc9beca23adf3c41e8852c186deb503e8bc2282c40
+
+build:


If I remember correctly, you also need to always_include the conda executable: http://conda.pydata.org/docs/building/meta-yaml.html#force-files.

Yeah, we are going to need to do that with a number of files.

Actually I'm wrong. We shouldn't need any as conda does not live in this environment. Though we may run into a nasty situation with the conda symlink. Care to comment on this point, @msarahan.

Neat. ( https://github.com/conda/conda/blob/e589b5156a3477396f88473b8c40acb61a3d5934/conda.recipe/meta.yaml#L11-L16 )

I think bin/activate and bin/deactivate might need to be in the always_include also, but this might only be needed on certain platforms.

From the conda repository

# These are present when the new environment is created # so we have to exempt them from the list of initial files # for conda-build to realize they should be included. always_include_files: - bin/conda [unix] - bin/activate [unix] - bin/deactivate [unix] - Scripts/activate.bat [win] - Scripts/deactivate.bat [win]

activate and deactivate both need to be in always_include (win needs them for bash support). Windows also needs the .bat files. There's a fish script, but I don't know where it goes. Issue here: conda/conda#2611

pelson · 2016-05-25T06:37:05Z

@jakirkham - indeed. Feel free to add me to all of these recipes.

pelson · 2016-05-25T06:37:24Z

I can also provide the working recipes I have once I am back at my desk.

jakirkham · 2016-06-02T04:02:59Z

@mcg1969, conda-build and conda-env are being dealt with here.

mcg1969 · 2016-06-02T04:07:44Z

This is great!

pelson · 2016-06-30T15:22:43Z

recipes/conda/meta.yaml

+  build:
+    - python
+    - conda-env
+    - pycosat


I don't think these are build deps - I don't seem to need these in my own recipe.

So, this is required for the solver. I'm pretty sure it should be there. Care to comment on this, @mcg1969?

I've never built a conda package for conda, frankly. These are certainly run dependencies but if it builds fine without them I see no reason to include them.

One thing about the conda-env dependency: please look at our dependencies carefully. It's important that conda-env and conda remain in rough version lock-step. For instance, conda 4.1.x requires conda-env >=2.5, and conda 4.0.x requires conda-env <2.5.

We also use ruamel_yaml for conda 4.1.

Not adding the conda-env version dependencies can cause catastrophic issues if someone tries to downgrade.

Yep, we had this chat before. This hasn't been touch in awhile. Thanks for the version pointers.

jakirkham · 2016-06-30T15:24:49Z

pycosat and requests don't need to be here any more as it cleared. Will remove.

pelson · 2016-06-30T15:25:50Z

👍 in principle. I have a few review comments, but nothing show-stopping.

conda-forge-linter · 2016-06-30T15:28:46Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda, recipes/conda-env) and found it was in an excellent condition.

jjhelmus · 2016-06-30T15:36:05Z

recipes/conda-env/meta.yaml

+
+build:
+  number: 0
+  script: python setup.py install


Does this need an entry point?

entry_points: - conda-env = conda_env.cli.main:main

The anaconda-recipes has it but not the repositories recipe

Probably. 😄 Good point. Will add.

Yeah, actually does someone want to clarify this discrepancy?

jjhelmus · 2016-06-30T15:45:32Z

Sorry for the barrage @jakirkham, would love to get this into conda-forge.

msarahan · 2016-07-05T21:32:53Z

I'm proposing to just not die if the files aren't there. They need to be there at the end, and we will clobber them if they are there. Nothing else matters.

I don't think pinning this is breaking anything. I'm confused on how this works, anyway, since conda nominally won't install itself into non-root environments, but some of these scripts and entry points should actually only be present in environments with conda installed.

jakirkham · 2016-07-05T22:14:12Z

Would commenting those Windows files in always_include_files be ok? It seems they don't appear in any build I've tried.

msarahan · 2016-07-06T20:10:55Z

conda/conda-build#1101 implements the relaxation of always_include_files

jakirkham · 2016-07-09T01:49:45Z

Restarting AppVeyor now that conda-build version 1.21.5 includes relaxed always_include_files. However, we may still have some issues due to version pinning on some builds. My suggestion would be if the bulk pass we resolve this with a workaround in the feedstock ATM. This is assuming there are no other issues worth addressing here at staged-recipes.

jakirkham · 2016-07-09T01:58:28Z

Just realized we are pinned to very old conda-build versions for all Windows builds. So, AppVeyor is still going to fail until we move them to a newer version.

jakirkham · 2016-07-16T22:31:12Z

Broke out our work here on conda-env into this PR ( #1064 ). I think it is probably ready to go with a few more tweaks.

jakirkham · 2016-07-16T22:37:02Z

Is there any chance we could get conda version 4.1.7 and 4.1.8 on PyPI given the issues we have had packaging them from GitHub, @kalefranz?

conda-forge-linter · 2016-07-17T01:29:12Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda) and found it was in an excellent condition.

jakirkham · 2016-08-04T20:36:59Z

So, I have fixed this up. It is now packaging the latest version of conda using a git tag from the repo. Also it uses the aforementioned hack to fix the version as proposed by @kalefranz.

Also it seems to be pulling in setuptools through one of its dependencies (probably ruamel_yaml). As a result, it had to be changed to use setuptools for the build.

During these changes, it was determined this now has a dependency on pyyaml. The dependency was added to the build and run requirements.

Some other changes were made like adding some more paths to the always include list.

jakirkham · 2016-08-04T20:47:49Z

Thus far this seems to be passing on the CIs now (including AppVeyor).

However, it fails on Windows Python 3.4 64-bit. This is actually not due to any problem with this recipe. Instead this is a consequence of our conda-build pinning in that case. In other words, we need to remove that pinning as proposed in PR ( conda-forge/conda-forge-build-setup-feedstock#22 ) to get this recipe for conda out. Until that is done we are blocked.

jakirkham · 2016-08-05T19:42:19Z

Closing and reopening to restart CIs.

jakirkham · 2016-08-05T20:03:05Z

Now passing and ready to go. 😄

jakirkham mentioned this pull request May 23, 2016

Collections of recipes needing attention? #161

Closed

jakirkham force-pushed the add_conda branch from c39ea13 to 6274c52 Compare May 23, 2016 04:29

jakirkham mentioned this pull request May 23, 2016

Add conda dependencies #657

Merged

pelson reviewed May 25, 2016
View reviewed changes

jakirkham force-pushed the add_conda branch from 6274c52 to 83fcf4c Compare May 25, 2016 14:47

jakirkham changed the title ~~WIP: Add conda~~ WIP: Add conda and conda-env May 25, 2016

pelson reviewed Jun 30, 2016
View reviewed changes

jakirkham force-pushed the add_conda branch from 83fcf4c to 2b8ea40 Compare June 30, 2016 15:28

jakirkham force-pushed the add_conda branch from 2b8ea40 to 4834e61 Compare June 30, 2016 15:29

jjhelmus reviewed Jun 30, 2016
View reviewed changes

jakirkham force-pushed the add_conda branch 2 times, most recently from e78b554 to b6773de Compare June 30, 2016 15:59

jakirkham force-pushed the add_conda branch from b95a8b9 to a99b9f4 Compare July 9, 2016 01:51

pelson mentioned this pull request Jul 10, 2016

v1.0 release conda-forge/conda-smithy#222

Closed

9 tasks

This was referenced Jul 16, 2016

conda-forge "miniconda" installer #1063

Closed

Add conda-env #1064

Merged

jakirkham force-pushed the add_conda branch from a99b9f4 to 7378382 Compare July 16, 2016 22:35

jakirkham changed the title ~~WIP: Add conda and conda-env~~ WIP: Add conda Jul 16, 2016

jakirkham force-pushed the add_conda branch from 7378382 to 7ef4391 Compare July 17, 2016 01:29

jakirkham force-pushed the add_conda branch 3 times, most recently from 2240d81 to 8e8132a Compare August 4, 2016 20:35

pelson changed the title ~~WIP: Add conda~~ Add conda Aug 5, 2016

jakirkham closed this Aug 5, 2016

jakirkham reopened this Aug 5, 2016

jakirkham force-pushed the add_conda branch from 8e8132a to 1bffa8b Compare August 6, 2016 20:37

conda: Add a recipe to build conda.

ffdf59d

jakirkham force-pushed the add_conda branch from 1bffa8b to ffdf59d Compare August 7, 2016 16:49

pelson merged commit 2111740 into conda-forge:master Aug 8, 2016

jakirkham deleted the add_conda branch August 8, 2016 14:35

Add conda #656

Add conda #656

Conversation

jakirkham commented May 23, 2016

conda-forge-linter commented May 23, 2016

jakirkham commented May 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelson commented May 25, 2016

pelson commented May 25, 2016

jakirkham commented Jun 2, 2016

mcg1969 commented Jun 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Jun 30, 2016 • edited Loading

pelson commented Jun 30, 2016

conda-forge-linter commented Jun 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjhelmus commented Jun 30, 2016

msarahan commented Jul 5, 2016

jakirkham commented Jul 5, 2016

msarahan commented Jul 6, 2016

jakirkham commented Jul 9, 2016

jakirkham commented Jul 9, 2016 • edited Loading

jakirkham commented Jul 16, 2016

jakirkham commented Jul 16, 2016 • edited Loading

conda-forge-linter commented Jul 17, 2016

jakirkham commented Aug 4, 2016

jakirkham commented Aug 4, 2016

jakirkham commented Aug 5, 2016

jakirkham commented Aug 5, 2016

jakirkham commented Jun 30, 2016 •

edited

Loading

jakirkham commented Jul 9, 2016 •

edited

Loading

jakirkham commented Jul 16, 2016 •

edited

Loading