Vs2008 appveyor cmake #617

msarahan · 2016-05-14T01:57:40Z

This should replace the 4 lines at https://github.com/conda/conda-build/blob/master/appveyor.yml#L71-L74, and be includable in meta.yaml as a build requirement. Still would be nicer to not need this at all, but I think this is about as clean as we can make it.

cc @patricksnape @jakirkham @pelson @ocefpaf

@patricksnape I added you as a maintainer, since you blazed this trail. Let me know if that's not OK.

License is unknown. What should we put?

conda-forge-linter · 2016-05-14T01:57:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vs2008_express_vc_python_patch) and found some lint.

Here's what I've got...

For recipes/vs2008_express_vc_python_patch:

The home item is expected in the about section.
The license item is expected in the about section.

jakirkham · 2016-05-14T03:46:07Z

License is unknown. What should we put?

In the past we have done BSD 3-Clause (e.g. vc). Seems ok to do the same here. Not sure what others think.

jakirkham · 2016-05-14T03:48:01Z

recipes/vs2008_express_vc_python_patch/meta.yaml

+  version: 1.0
+
+source:
+  url: https://github.com/menpo/condaci/raw/master/vs2008_patch.zip


Should we pick a tag or commit maybe?

v0.4.8 is the latest tag.

Should add that personally I would also be ok with just including those files with the recipe. This seems like a special case recipe where that is totally appropriate.

Part of the reason I say that, @pelson, is because @patricksnape plans to remove these from his repo. So, it might be best for both of us if they live somewhere new. Here seems like as good as any place.

Should add there are other cases where we are making the same decision (e.g. the toolchain, conda-forge-build-setup, etc.)

It isn't ideal but if necessary I'm not against it.
Does this whole package need to be put in conda-forge-build-setup? At least, I guess that should be the package which depends on this one?

IMHO it would be nice to keep this separate if this is an option. That way someone has the option of running this locally if needed. Though I'm perfectly fine with making it a dependency of conda-forge-build-setup and running it in the scripts there.

What do you think @msarahan and @patricksnape?

As mentioned below, the copying into Program Files would be problematic.

I've been persuaded. Moving this to conda-forge-build-setup seems like the best way forward.

Liking the separate package still for local use though.

pelson · 2016-05-14T11:42:29Z

So what is the deal, do we just install this when we install conda-build in AppVeyor and everything works? I assume the intention is not to make this an explicit dependency in the recipes?

patricksnape · 2016-05-15T09:39:53Z

Yeah if you install this as a build-dep it will fix Appveyor - very smart idea @msarahan!

patricksnape · 2016-05-15T09:40:51Z

We probably only want to run it on x64?

jakirkham · 2016-05-18T02:27:38Z

So, there are a few ways I could see one going with this.

Make it a build dependency of recipes on Windows.
Make this a run time dependency of the toolchain ( Add a recipe to configure our toolchain #578 ) on Windows.
Install it in the root environment in the AppVeyor CI scripts.

Ideally, I would want to go for 3 because there is one line that would muck with a user's system. In the worst case, I could get behind 2 if we automatically disable that one line somehow, but provide the option to override it. We should really avoid 1. If we are looking at that closely and 3 is not achievable, we should just go for 2. Though I'm really hoping 3 is an option.

pelson · 2016-05-18T04:04:59Z

Install it in the root environment in the AppVeyor CI scripts.

👍 - I have been wanting an excuse to implement a metapackage which is installed before we conda-build for a little while now, seems like now is the time to do that. We can make this package a runtime dependency of that metapackage on Windows. Controlling things like the conda-build version would also be in scope for that metapackage.

jakirkham · 2016-06-27T01:31:39Z

recipes/vs2008_express_vc_python_patch/post-link.bat

@@ -0,0 +1,2 @@
+call %PREFIX%\Scripts\setup_x64.bat
+copy "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\vcvars64.bat" "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\amd64\vcvarsamd64.bat"


I'd much prefer explicit to implicit given what this is doing. Could we please make this a proper script that one calls explicitly?

jakirkham · 2016-06-27T01:33:21Z

cc @JanSchulz

jankatins · 2016-06-27T10:30:57Z

Just for reference:Make it a build dependency of recipes on Windows. is IMO a nogo: copying to C:\Program Files (x86) is restricted to admin rights and I don't want to run local builds with admin rights.

IMO this should be part of a "If you want to have a proper build environment, you need a working VS install, which includes this fix. You can achieve that fix by installing the vs2008_express_vc_python_patch package with admin rights." wiki page detailing how to setup conda locally or on a CI service.

IMO adding this thing to a script (aka "...and you then have to run ... as admin") would also make it failsaver as some checks could be added: is VS installed,... On my system, I don't have "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\vcvars64.bat", only

C:\Users\jschulz\AppData\Local\Programs\Common\Microsoft\Visual C++ for Python\9.0\VC\bin\vcvars64.bat
# [and the one from 10.0 and 14.0 under C:\Program Files (x86)\]

I do have:

C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\amd64\vcvarsamd64.bat

jakirkham · 2016-07-02T20:23:51Z

Just for reference:Make it a build dependency of recipes on Windows. is IMO a nogo: copying to C:\Program Files (x86) is restricted to admin rights and I don't want to run local builds with admin rights.

Totally agree @JanSchulz. This came up in a question awhile back so I put it on the list. I think we have all nixed it. I think we have all since agreed that 3 ("Install it in the root environment in the AppVeyor CI scripts.") would be the way to go. Though may be that we do this via conda-forge-build-setup at conda-forge.

IMO this should be part of a "If you want to have a proper build environment, you need a working VS install, which includes this fix. You can achieve that fix by installing the vs2008_express_vc_python_patch package with admin rights." wiki page detailing how to setup conda locally or on a CI service.

Absolutely. This should be an option for people to correctly configure their build environment.

...some checks could be added...

Definitely we should add some checks for common cases so as not to mess up a user's environment. Are those the only cases you know of? Would you mind making a list of such cases to check (especially if there are more).

jakirkham · 2016-07-13T19:55:21Z

Any chance we can get this moving again? Should someone step up to finish this or will you have time to finish this one out @msarahan?

patricksnape · 2016-07-14T07:57:47Z

This fix is important if you want CMake to work on Appveyor - with the latest conda-build it shouldn't be required for setuptools packages due to the existence of the Visual C++ for Python package on Appveyor. Perhaps this fix should live in something specific to Appveyor/conda-forge and we should just make sure to have a Wiki page (as @JanSchulz suggested) that explains how to fix this for local/custom builds?

jakirkham · 2016-09-07T06:59:37Z

What about conda-forge-build-setup?

jakirkham · 2016-09-28T02:44:17Z

If you have some time, @shadowwalkersb , I'd recommend taking a look at this and trying to clean it up. This does basically the same thing as what you were trying to do with freeglut. Though it would be a package one could install to make Python 2.7/VS 2008 64-bit builds work correctly.

xref: conda-forge/freeglut-feedstock#2 (diff)

jakirkham · 2016-09-28T19:24:59Z

Please see PR ( #1678 ), which has taken over this. IMHO that is ready to go, but think it is probably healthy for people to take a cursory look at it before it is merged.

msarahan added 2 commits May 13, 2016 20:53

add script to set up VS 2008 for CMake on appveyor

12fb52b

whitespace

aeba662

jakirkham reviewed May 14, 2016
View reviewed changes

jakirkham mentioned this pull request May 18, 2016

Add a recipe to configure our toolchain #578

Merged

jankatins mentioned this pull request May 25, 2016

WIP: CI: Incorporate workaround so as to support 64-bit VS 2008 conda-forge/conda-smithy#107

Closed

jakirkham reviewed Jun 27, 2016
View reviewed changes

jakirkham mentioned this pull request Jul 13, 2016

Re-incorporate workaround for 64-bit VS 2008 Support #607

Closed

jakirkham mentioned this pull request Sep 7, 2016

Visual Studio 9 2008 Win64 builds fail on AppVeyor: The specified configuration type is missing. The tools for the configuration might not be installed. conda/conda-build#1327

Closed

jakirkham mentioned this pull request Sep 28, 2016

Add Windows recipe conda-forge/freeglut-feedstock#2

Merged

shadowwalkersb mentioned this pull request Sep 28, 2016

Vs2008 appveyor cmake #1678

Merged

jakirkham mentioned this pull request Oct 9, 2016

Collections of recipes needing attention? #161

Closed

patricksnape closed this in #1678 Oct 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vs2008 appveyor cmake #617

Vs2008 appveyor cmake #617

msarahan commented May 14, 2016

conda-forge-linter commented May 14, 2016

jakirkham commented May 14, 2016

jakirkham May 14, 2016

patricksnape May 15, 2016

jakirkham May 18, 2016

jakirkham Jun 14, 2016

jakirkham Jun 14, 2016

pelson Jun 30, 2016

jakirkham Jul 2, 2016 •

edited

Loading

patricksnape Jul 7, 2016 •

edited

Loading

jakirkham Sep 7, 2016

jakirkham Sep 28, 2016

pelson commented May 14, 2016

patricksnape commented May 15, 2016

patricksnape commented May 15, 2016

jakirkham commented May 18, 2016 •

edited

Loading

pelson commented May 18, 2016

jakirkham Jun 27, 2016

jakirkham commented Jun 27, 2016

jankatins commented Jun 27, 2016

jakirkham commented Jul 2, 2016

jakirkham commented Jul 13, 2016

patricksnape commented Jul 14, 2016

jakirkham commented Sep 7, 2016

jakirkham commented Sep 28, 2016

jakirkham commented Sep 28, 2016

		@@ -0,0 +1,2 @@
		call %PREFIX%\Scripts\setup_x64.bat
		copy "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\vcvars64.bat" "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\amd64\vcvarsamd64.bat"

Vs2008 appveyor cmake #617

Vs2008 appveyor cmake #617

Conversation

msarahan commented May 14, 2016

conda-forge-linter commented May 14, 2016

jakirkham commented May 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham Jul 2, 2016 • edited Loading

Choose a reason for hiding this comment

patricksnape Jul 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelson commented May 14, 2016

patricksnape commented May 15, 2016

patricksnape commented May 15, 2016

jakirkham commented May 18, 2016 • edited Loading

pelson commented May 18, 2016

Choose a reason for hiding this comment

jakirkham commented Jun 27, 2016

jankatins commented Jun 27, 2016

jakirkham commented Jul 2, 2016

jakirkham commented Jul 13, 2016

patricksnape commented Jul 14, 2016

jakirkham commented Sep 7, 2016

jakirkham commented Sep 28, 2016

jakirkham commented Sep 28, 2016

jakirkham Jul 2, 2016 •

edited

Loading

patricksnape Jul 7, 2016 •

edited

Loading

jakirkham commented May 18, 2016 •

edited

Loading