add sompy and portalocker #4451
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/portalocker:
For recipes/sompy:
|
| @@ -0,0 +1,2 @@ | |||
| "%PYTHON%" setup.py install | |||
There was a problem hiding this comment.
Can we get rid of the bld.bat and build.sh in favor of the script entry in the meta.yaml files:
| source: | ||
| fn: {{ name }}-{{ version }}.tar.gz | ||
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} |
|
|
||
| requirements: | ||
| build: | ||
| - python |
There was a problem hiding this comment.
Can you add setuptools to the build requirements?
| about: | ||
| home: http://portalocker.readthedocs.org/en/latest/ | ||
| license: PSF | ||
| summary: 'Portalocker is a library to provide an easy API to file locking.' |
There was a problem hiding this comment.
dev_url: https://github.com/WoLpH/portalocker
|
|
||
| about: | ||
| home: http://portalocker.readthedocs.org/en/latest/ | ||
| license: PSF |
| @@ -0,0 +1,2 @@ | |||
| "%PYTHON%" setup.py install --single-version-externally-managed --record record.txt | |||
There was a problem hiding this comment.
Drop bld.bat and build.sh in favor of script entry in meta.yaml
| source: | ||
| fn: {{ name }}-{{ version }}.tar.gz | ||
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} |
| build: | ||
| - python | ||
| - setuptools | ||
| - numpy |
There was a problem hiding this comment.
It doesn't look like numpy is a build requirement if using --single-version-externally-managed
|
|
||
| run: | ||
| - python | ||
| - numpy |
There was a problem hiding this comment.
It looks like matplotlib is also a run requirement. It's not evident when looking at the code up on github, but in the tarball version of the code, it's imported:
|
|
||
| about: | ||
| home: https://github.com/ttlg/sompy | ||
| license: MIT License |
There was a problem hiding this comment.
license: MIT
Also, please manually package the license_file and submit an issue/PR upstream, adding the url to the issue as a comment in the recipe.
https://conda-forge.org/docs/meta.html#packaging-the-license-manually
|
FYI: portalocker was added to conda-forge in #5092. |
|
@daler I added Clust to Bioconda in this PR: bioconda/bioconda-recipes#11619 @npavlovikj thoughtfully submitted a Sompy recipe to Bioconda so that my PR could be merged, but I agree that it fits conda-forge better. |
|
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the Cheers and thank you for contributing to this community effort! |
|
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
These are deps for https://github.com/BaselAbujamous/clust which will then be added to bioconda.