Skip to content

Adding ninja-python#31325

Closed
lllangWV wants to merge 5 commits intoconda-forge:mainfrom
lllangWV:python-ninja
Closed

Adding ninja-python#31325
lllangWV wants to merge 5 commits intoconda-forge:mainfrom
lllangWV:python-ninja

Conversation

@lllangWV
Copy link
Copy Markdown
Contributor

@lllangWV lllangWV commented Oct 28, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Oct 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18888513468. Examine the logs at this URL for more detail.

- added homepage item in about section
- added maintainer in extra/recipe-maintainers section
- add build number,
- removed version requirements for non noarch packages
- added ${{ stdlib("c") }}
…ts, removed unnecessary entries, and streamlined run section for better clarity.
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ninja-python/recipe.yaml) and found it was in an excellent condition.

@lllangWV
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please ping conda-forge/help-python`

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python` and so here I am doing that.

Copy link
Copy Markdown
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vendors in ninja right?

@lllangWV
Copy link
Copy Markdown
Contributor Author

Hey @isuruf,

Yes, this does vendor ninja.

Context: I'm working to add spconv to conda-forge, which has this dependency chain:

  • spconv → cumm → ccimport → ninja (Python package)

The ccimport package imports the ninja Python module (not just the executable),
so it needs the Python API that ninja-python provides (like ninja_syntax.py).

I called it ninja-python to distinguish it from the existing ninja package on
conda-forge which only provides the executable.

I also noticed another conda-forge package called https://anaconda.org/conda-forge/ninja_syntax. However I tried install this and then running ccimport and this did not solve my issue.

What is your suggestion to go about this?

@isuruf
Copy link
Copy Markdown
Member

isuruf commented Oct 29, 2025

There's more info at #19098

@lllangWV
Copy link
Copy Markdown
Contributor Author

@isuruf , thanks for find that discussion!

I am going to close this pull request. Instead I am going to put a pull request into ccimport to allow it to be compatible with conda-forge without going through the ninja-python dependency.

FindDefinition/ccimport#2

@lllangWV lllangWV closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants