Add `array-record` feedstock by mtsokol · Pull Request #30587 · conda-forge/staged-recipes

mtsokol · 2025-07-21T08:45:36Z

Checklist

github-actions · 2025-07-21T08:46:52Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2025-07-21T08:47:08Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

github-actions · 2025-07-21T08:51:15Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/array-record/meta.yaml:
- lints:
  - The following maintainers have not yet confirmed that they are willing to be listed here: iindyk. Please ask them to comment on this PR if they are.

conda-forge-admin · 2025-07-21T08:51:34Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/array-record/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/array-record/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16471335616. Examine the logs at this URL for more detail.}

mtsokol · 2025-07-21T08:52:59Z

Hi @iindyk we need your comment to confirm you'll also be a maintainer of the stock.

iindyk · 2025-07-21T17:24:33Z

Hello, yes, I'm willing to be a maintainer of the stock.

github-actions · 2025-07-22T19:44:13Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

mtsokol · 2025-07-22T20:50:58Z

@conda-forge-admin, please ping team

conda-forge-webservices · 2025-07-22T20:51:04Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

github-actions · 2025-07-22T20:51:13Z

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

mtsokol · 2025-07-22T20:57:00Z

@conda-forge/help-python

danielnachun · 2025-07-23T01:10:31Z

+rsync -avm -L  --include="*.so" --include="*_pb2.py" \
+  --exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \
+  bazel-bin/cpp "${TMPDIR}/array_record"
+rsync -avm -L  --include="*.so" --include="*_pb2.py" \
+  --exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \
+  bazel-bin/python "${TMPDIR}/array_record"


Suggested change

rsync -avm -L --include="*.so" --include="*_pb2.py" \

--exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \

bazel-bin/cpp "${TMPDIR}/array_record"

rsync -avm -L --include="*.so" --include="*_pb2.py" \

--exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \

bazel-bin/python "${TMPDIR}/array_record"

rsync -avm -L --include="*${SHLIB_EXT}" --include="*_pb2.py" \

--exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \

bazel-bin/cpp "${TMPDIR}/array_record"

rsync -avm -L --include="*${SHLIB_EXT}" --include="*_pb2.py" \

--exclude="*.runfiles" --exclude="*_obj" --include="*/" --exclude="*" \

bazel-bin/python "${TMPDIR}/array_record"

danielnachun · 2025-07-23T01:11:34Z

+    read, write, and random access by record index. ArrayRecord builds on top of Riegeli
+    and supports the same compression algorithms.
+  license: Apache-2.0
+  license_family: Apache


Suggested change

license_family: Apache

danielnachun · 2025-07-23T01:12:48Z

+  number: 0
+  skip: true  # [py<310]
+  skip: true  # [win]
+  skip: true  # [osx]


Suggested change

skip: true # [osx]

Let's enable macOS and see what it takes for it to build. Given that this is a bazel build, I won't ask for us to try Windows until the feedstock exists.

I would prefer to skip osx for now:

Unfortunately array-record doesn't support MacOS x86 so it won't even compile here.

For MacOS ARM it will only apply once we get a feedstock - so I want to work on it in a follow-up PR.

Okay, bazel is a such a painful system to build with we can get by for now only Linux but let's make sure check into macOS arm64 afterward. The build failure you linked seems to be more of an issue with how highway-hash was built than something specific to macOS x86, but it's so difficult to debug bazel that I don't have any suggestions yet.

mtsokol · 2025-07-24T21:43:53Z

@conda-forge/help-python It's ready for another review!

ehfd · 2025-07-26T12:01:53Z

Thank you for making this work!

ehfd · 2025-07-26T12:03:25Z

Please also take a look at conda-forge/tensorflow-datasets-feedstock#23 and #29008, which could benefit downstream.

mtsokol · 2025-07-28T09:43:46Z

@ehfd Sure! I'll take a look at some time. This feedstock is required downstream for Grain as well - #30294.

mtsokol · 2025-07-29T08:56:38Z

@conda-forge/help-python It's ready for review!

mtsokol · 2025-08-07T09:36:54Z

@conda-forge/help-python It's ready for review!

ehfd · 2025-08-07T10:21:04Z

Adequate reviewers should be at @conda-forge/help-c-cpp or @conda-forge/help-python-c.

The tag you used is for pure Python.

danielnachun

I think this is probably ready to merge (notwithstanding the question about using the alpha tag), but @mtsokol please be aware that our ability to support bazel packages in conda-forge is extremely limited because the design of bazel is entirely antithetical to what we do here.

danielnachun · 2025-08-11T19:43:18Z

+  number: 0
+  skip: true  # [py<310]
+  skip: true  # [win]
+  skip: true  # [osx]


Okay, bazel is a such a painful system to build with we can get by for now only Linux but let's make sure check into macOS arm64 afterward. The build failure you linked seems to be more of an issue with how highway-hash was built than something specific to macOS x86, but it's so difficult to debug bazel that I don't have any suggestions yet.

danielnachun · 2025-08-11T19:47:07Z

@@ -0,0 +1,73 @@
+{% set name = "array-record" %}
+{% set version = "0.8.0a1" %}


Normally we don't allow alpha tags on here, but I'm somewhat inclined to grant an exception here because this a bazel project and we're lucky it even has tags at all. Any thoughts on this from the rest of @conda-forge/staged-recipes?

we can get by for now only Linux

conda-forge/tensorflow-datasets-feedstock#23
array-record is a major bottleneck for tensorflow-datasets, where this is dependent on Linux, so having even just Linux will help a lot.

mtsokol · 2025-08-12T07:35:32Z

Okay, bazel is a such a painful system to build with we can get by for now only Linux but let's make sure check into macOS arm64 afterward.

@danielnachun Sure, thanks! Once we have a feedstock the next thing I will work on is MacOS ARM support. This one is already build for PyPI, contrary to MacOS x86 which isn't build there. So I guess potential MacOS x86 support will first take to build it for pip, and then conda-forge feedstock in the future.

mtsokol force-pushed the array-record branch from 064d681 to 9726a57 Compare July 21, 2025 08:49

mtsokol force-pushed the array-record branch 4 times, most recently from f1db543 to b3c45ab Compare July 21, 2025 13:23

Add array-record feedstock

4b9e51b

mtsokol force-pushed the array-record branch from b3c45ab to 4b9e51b Compare July 22, 2025 19:42

github-actions Bot added review-requested staged-recipes labels Jul 22, 2025

github-actions Bot added the python label Jul 22, 2025

danielnachun requested changes Jul 23, 2025

View reviewed changes

Apply review comments

3b30f54

mtsokol requested a review from danielnachun July 23, 2025 14:08

xhochy mentioned this pull request Jul 25, 2025

Add array_record recipe #29033

Closed

10 tasks

github-actions Bot added python-c c-cpp labels Aug 7, 2025

danielnachun reviewed Aug 11, 2025

View reviewed changes

mtsokol requested a review from danielnachun August 18, 2025 07:12

danielnachun approved these changes Aug 19, 2025

View reviewed changes

danielnachun merged commit 21c5814 into conda-forge:main Aug 19, 2025
7 checks passed

mtsokol deleted the array-record branch August 19, 2025 21:25

ehfd mentioned this pull request Aug 20, 2025

Update tensorflow-datasets conda-forge/tensorflow-datasets-feedstock#23

Closed

5 tasks

mtsokol mentioned this pull request Nov 11, 2025

Add Grain feedstock #30294

Merged

10 tasks

		@@ -0,0 +1,73 @@
		{% set name = "array-record" %}
		{% set version = "0.8.0a1" %}

Uh oh!

Conversation

mtsokol commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2025

Uh oh!

conda-forge-admin commented Jul 21, 2025

Uh oh!

github-actions Bot commented Jul 21, 2025

Uh oh!

conda-forge-admin commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtsokol commented Jul 21, 2025

Uh oh!

iindyk commented Jul 21, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

mtsokol commented Jul 22, 2025

Uh oh!

conda-forge-webservices Bot commented Jul 22, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

mtsokol commented Jul 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtsokol commented Jul 24, 2025

Uh oh!

ehfd commented Jul 26, 2025

Uh oh!

ehfd commented Jul 26, 2025

Uh oh!

mtsokol commented Jul 28, 2025

Uh oh!

mtsokol commented Jul 29, 2025

Uh oh!

mtsokol commented Aug 7, 2025

Uh oh!

ehfd commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielnachun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtsokol commented Aug 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mtsokol commented Jul 21, 2025 •

edited

Loading

conda-forge-admin commented Jul 21, 2025 •

edited

Loading

ehfd commented Aug 7, 2025 •

edited

Loading