Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conda package for drug2cell tool #28395

Closed
wants to merge 11 commits into from

Conversation

Mennayousef
Copy link

I am attempting to create a conda recipe package for drug2cell tool.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 28, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/drug2cell/meta.yaml) and found some lint.

Here's what I've got...

For recipes/drug2cell/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • requirements: host: python >= 9999 should not contain a space between relational operator and the version, i.e. python >=9999
  • requirements: run: python >= 9999 should not contain a space between relational operator and the version, i.e. python >=9999

For recipes/drug2cell/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12074817681. Examine the logs at this URL for more detail.

Copy link

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/drug2cell/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: mennayousef. Please ask them to comment on this PR if they are.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/drug2cell/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/drug2cell/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12074840935. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/drug2cell/meta.yaml) and found some lint.

Here's what I've got...

For recipes/drug2cell/meta.yaml:

  • ❌ The recipe must have some tests.

For recipes/drug2cell/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12075053995. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/drug2cell/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/drug2cell/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12075173996. Examine the logs at this URL for more detail.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time on this! Unfortunately, I'm not for merging this as it stands.

Conda Forge packages should be properly versioned, either through PyPI or GitHub Releases rather from a commit hash, which is mutable. My recommendation is either that one gets the lab to commit to making releases of some form, or instead move this to Bioconda, which aligns with the intent of the package and also has a lower bar for recipe standards.

@mfansler
Copy link
Member

mfansler commented Dec 2, 2024

Just noticed that this was merged on Bioconda (bioconda/bioconda-recipes#52452). As a noarch recipe, there will not be any advantage to shifting to Conda Forge, even with the version issue addressed. As such, I will close this.

@mfansler mfansler closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants