Add flang-activation by h-vetinari · Pull Request #27470 · conda-forge/staged-recipes

h-vetinari · 2024-09-03T04:20:29Z

conda-forge-webservices · 2024-09-03T04:20:40Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flang-activation/meta.yaml) and found some lint.

Here's what I've got...

For recipes/flang-activation/meta.yaml:

The following maintainers have not yet confirmed that they are willing to be listed here: isuruf. Please ask them to comment on this PR if they are.

h-vetinari · 2024-09-03T04:51:07Z

@isuruf, this should handle the flang compiler activation split, PTAL! :)

I added you as a maintainer, please let me know if you'd prefer not to be.

h-vetinari · 2024-09-04T20:41:02Z

Gentle ping @isuruf

Suggested-By: Isuru Fernando <isuruf@gmail.com>

Co-Authored-By: Isuru Fernando <isuruf@gmail.com>

conda-forge-webservices · 2024-09-05T00:54:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flang-activation/meta.yaml) and found it was in an excellent condition.

h-vetinari · 2024-09-05T01:08:44Z

Thanks for the review - that should all be fixed now.

For consistency with other conda-forge compilers, c.f. e.g. https://github.com/conda-forge/ctng-compiler-activation-feedstock/blob/main/recipe/activate-gcc.sh Suggested-By: Isuru Fernando <isuruf@gmail.com>

h-vetinari · 2024-09-06T03:32:41Z

Anything else here @isuruf?

h-vetinari · 2024-09-07T16:03:24Z

Gentle ping @isuruf

h-vetinari · 2024-09-10T13:10:25Z

Any last comments here @isuruf?

isuruf · 2024-09-10T14:02:40Z

+        # rename flang-new -> flang is happening soon:
+        # https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462


This comment seems irrelevant

This is an updated version from what we currently have in the flang feedstock. As it was looking like it would finally happen a few days ago (until the goalposts shifted yet again), I was debating with myself whether we want to do the rename for flang 19 already. Might make the fortran migration a bit simpler. 🤷

I didn't mean the contents of the comment. I was referring to why this comment needs to be in the test section. It seems irrelevant.

It's more visible in the recipe than in the activation script, and the test section is where we're using the name (or now, the value of FC).

This reverts commit b490300.

h-vetinari · 2024-09-10T15:02:51Z

Thanks for the review! 🙏

h-vetinari · 2024-09-10T15:34:00Z

Good to merge now?

Co-authored-by: Isuru Fernando <isuruf@gmail.com>

h-vetinari · 2024-09-10T16:31:26Z

Thanks for iterating on this. We can keep polishing things on the feedstock, flang 19.1.0 GA is around the corner anyway. :)

Add flang-activation

cbba006

add license

7b0d81b

This was referenced Sep 3, 2024

make flang a cross-compiler conda-forge/flang-feedstock#63

Closed

flang v19.1.0.rc4 conda-forge/flang-feedstock#71

Merged

isuruf reviewed Sep 4, 2024

View reviewed changes

Comment thread recipes/flang-activation/activate.sh Outdated

isuruf reviewed Sep 4, 2024

View reviewed changes

Comment thread recipes/flang-activation/meta.yaml Outdated

h-vetinari and others added 4 commits September 5, 2024 11:48

Do not touch CPATH/LIBRARY_PATH in unix activation

e4acd54

Suggested-By: Isuru Fernando <isuruf@gmail.com>

use FC for invoking flang in test

b2e42a1

Co-Authored-By: Isuru Fernando <isuruf@gmail.com>

remove global build env

b12599b

work around conda-build bug

f8c6c0b

h-vetinari added 2 commits September 5, 2024 12:01

fix mismatched rc's

b490300

limit lld dep to windows

80ea5f6

h-vetinari mentioned this pull request Sep 5, 2024

allow flang compilers to be built on flang-activation feedstock conda-forge/feedstock-outputs#89

Merged

isuruf reviewed Sep 5, 2024

View reviewed changes

Comment thread recipes/flang-activation/activate.sh Outdated

isuruf reviewed Sep 5, 2024

View reviewed changes

Comment thread recipes/flang-activation/activate.sh Outdated

h-vetinari added 2 commits September 5, 2024 21:43

do without CONDA_BUILD_SYSROOT in linux activation

33f0a04

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/meta.yaml Outdated

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/meta.yaml Outdated

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/meta.yaml Outdated

isuruf reviewed Sep 10, 2024

View reviewed changes

use BSD-3 license like ctng-compiler-activation

450d9a9

h-vetinari added 5 commits September 10, 2024 16:34

drop generic compiler-rt; keep target-specific one

7b650b6

don't pin lld; not necessary

3e69e7e

Revert "fix mismatched rc's"

6c5b7a2

This reverts commit b490300.

update comment w.r.t. binary name

d995d2f

bump to 19.1.0.rc4

3913bba

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/conda_build_config.yaml Outdated

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/activate.sh Outdated

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/activate.bat Outdated

set FC as $CHOST-flang on unix

463a8ec

h-vetinari force-pushed the flang branch from 1963a8d to 7e6c5c7 Compare September 10, 2024 14:59

h-vetinari added 2 commits September 10, 2024 17:01

remove CBUILD from zip_keys

b6d55f7

add to LDFLAGS on win, instead of overwriting

615ea74

h-vetinari force-pushed the flang branch from 7e6c5c7 to 615ea74 Compare September 10, 2024 15:01

isuruf reviewed Sep 10, 2024

View reviewed changes

Comment thread recipes/flang-activation/conda_build_config.yaml Outdated

isuruf approved these changes Sep 10, 2024

View reviewed changes

remove currently unused configuration

71de342

Co-authored-by: Isuru Fernando <isuruf@gmail.com>

h-vetinari merged commit 4f96b50 into conda-forge:main Sep 10, 2024

h-vetinari deleted the flang branch September 10, 2024 16:24

		# rename flang-new -> flang is happening soon:
		# https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462

Uh oh!

Conversation

h-vetinari commented Sep 3, 2024

Uh oh!

conda-forge-webservices Bot commented Sep 3, 2024

Uh oh!

h-vetinari commented Sep 3, 2024

Uh oh!

h-vetinari commented Sep 4, 2024

Uh oh!

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Sep 5, 2024

Uh oh!

h-vetinari commented Sep 5, 2024

Uh oh!

Uh oh!

Uh oh!

h-vetinari commented Sep 6, 2024

Uh oh!

h-vetinari commented Sep 7, 2024

Uh oh!

h-vetinari commented Sep 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isuruf Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

h-vetinari Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

isuruf Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

h-vetinari Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

h-vetinari commented Sep 10, 2024

Uh oh!

h-vetinari commented Sep 10, 2024

Uh oh!

Uh oh!

h-vetinari commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants